Visitar URL original
Updating HTML elements to map to their Aria 1.2 roles by scottaohara · Pull Request #348 · w3c/html-aam · GitHub
Skip to content

Updating HTML elements to map to their Aria 1.2 roles - #348

Merged
scottaohara merged 11 commits into
gh-pagesfrom
aria1-2roles
Nov 7, 2021
Merged

Updating HTML elements to map to their Aria 1.2 roles#348
scottaohara merged 11 commits into
gh-pagesfrom
aria1-2roles

Conversation

@scottaohara

@scottaohara scottaohara commented Sep 29, 2021 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Member

This pull request updates many elements to match the new roles introduced in ARIA 1.2 (working through issue #229), and which are in core aam. The updated elements are as follows:

  • blockquote
  • caption
  • code
  • del
  • em
  • ins
  • meter
  • paragraph
  • strong
  • sub
  • sup
  • time

NOTE: I have not presently updated the mapping for figcaption to the caption role. At various times, people have expressed their unhappiness with the figcaptoin element's current behavior, and the redundancy / verbosity impacts it has as the accessible name for figure. @jnurthen I would like to add this as a future agenda item to the ARIA wg call - specifically the group's feelings on changing figcaption to provide a description, rather than name – or some other alternative.

Additionally, this PR fixes the mappings for body, htmland hgroup

Further, some updates to remove the mention of "?" cells from the 3.4 introduction, and that UAs must not expose aria-roledescription on generic elements.

Lastly, this PR updates the following elements which map to generic (or will map to generic under certain conditions). This, along with the updates to body and hgroup starts the work on #346.

Preview | Diff

Preview | Diff

@scottaohara
blockquote update
3f31440 
map to core aam blockquote role
@scottaohara
fix mapping for body/html
847b466 
`html` should have mapped to `document` - this is now corrected and the table now indicates to refer to the WAI-ARIA mapping for the document role.

`body` no longer maps to `document` - which matches reality.  `body` now maps to `role=generic`.   further updates may be needed here for instances where authors incorrectly name a generic / provide the body with elements important to accessibility - e.g., `contenteditable`.

closes #330
@scottaohara
update section 3.4 introduction list
cc4bf04 
* remove bullet about “?” cells.  these have all been removed.
* update list item about `aria-roledescription` and mention that UAs must not expose the attribute if used on an implicit `generic` element.
@scottaohara
update aria 1.1 to 1.2 links
5937aa9
@scottaohara
update json data for specs
292e629
@scottaohara
update hgroup mapping to match reality
02039ce 
closes #331
@scottaohara
point to aria 1.2 roles
34c10e7 
this PR updates the following elements to point to their implicit ARIA roles defined in core aam

* caption
* code
* del
* em
* ins
* meter
* paragraph
* strong
* sub
* sup
* time
@scottaohara
start marking generics
cbda1a2 
starts on issue #346, indicate some of the elements that will map to, or under certain conditions map to `generic`

* autonomous custom elements
* div
* form without accessible name
* form associated custom elements
* section without accessible name
@jnurthen
jnurthen requested a review from cyns October 7, 2021 17:15
@scottaohara

scottaohara commented Oct 26, 2021

Copy link
Copy Markdown
Member Author

per my mention about speaking to the WG regarding figcaption, there was consensus in the working group to not have figcaption contribute to the accessible name of a figure. instead, it was suggested that an aria-details association between the figure and the figcaption seemed to make the most sense, since a figcaption can contain structured and interactive content that would be less meaningful as a flattened text string (name or description).

all that said, this PR will not be updated to map figcaption to the caption role

joanmarie
joanmarie requested changes Nov 2, 2021
View reviewed changes

@joanmarie joanmarie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments related to the details mapping change.

Comment thread index.html Resolved
Comment thread index.html Resolved
Comment thread index.html Resolved
@scottaohara
scottaohara requested a review from joanmarie November 2, 2021 19:39
@joanmarie

joanmarie commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

LGTM. Thanks!

@scottaohara
scottaohara merged commit 538a078 into gh-pages Nov 7, 2021
@scottaohara
scottaohara deleted the aria1-2roles branch November 7, 2021 18:39
@scottaohara scottaohara mentioned this pull request Mar 7, 2022
Merged
4 tasks
@dd8 dd8 mentioned this pull request Dec 19, 2022
Open
@jlp-craigmorten jlp-craigmorten mentioned this pull request Jun 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevefaulkner stevefaulkner stevefaulkner approved these changes
@joanmarie joanmarie joanmarie approved these changes
@cyns cyns Awaiting requested review from cyns

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hgroup mappings do not seem correct Mappings for body and html don't seem to match reality

3 participants

@scottaohara @joanmarie @stevefaulkner