Visitar URL original
Add `RawPostgresql` based on `RawSqlite` by ivb-supercede · Pull Request #1305 · yesodweb/persistent · GitHub
Skip to content

Add RawPostgresql based on RawSqlite - #1305

Merged
parsonsmatt merged 5 commits into
yesodweb:masterfrom
SupercedeTech:raw-postgresql
Sep 6, 2021
Merged

Add RawPostgresql based on RawSqlite#1305
parsonsmatt merged 5 commits into
yesodweb:masterfrom
SupercedeTech:raw-postgresql

Conversation

@ivb-supercede

@ivb-supercede ivb-supercede commented Aug 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Based on the discussion in #1298.

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@ivb-supercede
Add RawPostgresql backend which exposes connection
688474e 
As part of the discussion in #1298, it was found that
external libraries which want to hook into Persistent's Postgres API are
limited by their inability to access the postgresql-simple `Connection`
which backs a Postgres `SqlBackend`.

A similar issue in the past with Sqlite was solved by the `RawSqlite`
wrapper, which is able to expose the raw connection as well as be
compatible with the wrapped `SqlBackend` that it stores.

This adds an equivalent wrapper to persistent-postgresql, which exposes
the raw connection, and therefore allows third-party libraries to access
it.
@ivb-supercede
Run stylish-haskell on Postgresql.hs
191b17b
@ivb-supercede
Add ChangeLog entry for 2.13.1.0
7f183bd
parsonsmatt
parsonsmatt requested changes Aug 30, 2021
View reviewed changes

@parsonsmatt parsonsmatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

Let's not introduce microlens dependency and lens generation. I know it was copied from SQLite, but it's not something I'd like to repeat.

Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Resolved
Comment thread persistent-postgresql/persistent-postgresql.cabal Resolved
Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Resolved
Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Resolved
ivb-supercede
ivb-supercede commented Aug 31, 2021
View reviewed changes
Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Resolved
ivb-supercede
ivb-supercede commented Aug 31, 2021
View reviewed changes
Comment thread persistent-postgresql/Database/Persist/Postgresql.hs Resolved
ivb-supercede and others added 2 commits August 31, 2021 14:51
@ivb-supercede @parsonsmatt
Remove microlens dependency, expose RawPostgresql fields
44766b3 
This was requested as part of the review on #1305.

Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
@ivb-supercede
Fix backwards-compatibility of Postgresql.hs
87ff574
@parsonsmatt
parsonsmatt merged commit 02fb1e1 into yesodweb:master Sep 6, 2021
@parsonsmatt

parsonsmatt commented Sep 6, 2021

Copy link
Copy Markdown
Collaborator

Thanks so much! I'll get this released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivb-supercede @parsonsmatt