Visitar URL original
Finalize type lits by parsonsmatt · Pull Request #1388 · yesodweb/persistent · GitHub
Skip to content

Finalize type lits - #1388

Merged
parsonsmatt merged 2 commits into
masterfrom
matt/finalize-type-lit-pr
Apr 12, 2022
Merged

Finalize type lits#1388
parsonsmatt merged 2 commits into
masterfrom
matt/finalize-type-lit-pr

Conversation

@parsonsmatt

@parsonsmatt parsonsmatt commented Apr 12, 2022

Copy link
Copy Markdown
Collaborator

Continuation of #1343

Fixes #562

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

danbroooks and others added 2 commits April 11, 2022 22:18
@danbroooks @parsonsmatt
Implement Type Literal based field definitions (#1343)
c3886bf 
* Implement typelit field definitions

* Some cleanup

* Sort indentation and add PR link in changelog

* Move location of exposed type

Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
@parsonsmatt
fix tests
24152e1
@parsonsmatt parsonsmatt added this to the 2.14 milestone Apr 12, 2022
@parsonsmatt
parsonsmatt merged commit c3f0577 into master Apr 12, 2022
@parsonsmatt
parsonsmatt deleted the matt/finalize-type-lit-pr branch April 12, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.14

Development

Successfully merging this pull request may close these issues.

Persistent Entity Declaration QuasiQuote doesn't support type literals

2 participants

@parsonsmatt @danbroooks