Visitar URL original
Remove extraneous `map toPersistValue` call. by arrowd · Pull Request #1468 · yesodweb/persistent · GitHub
Skip to content

Remove extraneous map toPersistValue call. #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parsonsmatt merged 1 commit into from
Feb 1, 2023
Merged

Remove extraneous map toPersistValue call. #1468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions persistent/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog for persistent

## unreleased

* [#1460] https://github.com/yesodweb/persistent/pull/1468
* Remove extraneous `map toPersistValue` call in the `mkInsertValues`
function, as it evaluates to `id`.

## 2.14.4.4

* [#1460] https://github.com/yesodweb/persistent/pull/1460
Expand Down
1 change: 0 additions & 1 deletion persistent/Database/Persist/Sql/Util.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ mkInsertValues
mkInsertValues entity =
Maybe.catMaybes
. zipWith redactGeneratedCol (getEntityFields . entityDef $ Just entity)
. map toPersistValue
$ toPersistFields entity
where
redactGeneratedCol fd pv = case fieldGenerated fd of
Expand Down