Visitar URL original
fix: populate `p.sbomViewFiles` on `deploy` and `mirror` by lucasrod16 · Pull Request #2386 · zarf-dev/zarf · GitHub
Skip to content

fix: populate p.sbomViewFiles on deploy and mirror - #2386

Merged
Noxsios merged 2 commits into
mainfrom
fix-sbomViewFiles-on-deploy
Mar 19, 2024
Merged

fix: populate p.sbomViewFiles on deploy and mirror#2386
Noxsios merged 2 commits into
mainfrom
fix-sbomViewFiles-on-deploy

Conversation

@lucasrod16

@lucasrod16 lucasrod16 commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

Description

Refactoring that took place in #2223 introduced a bug on deploy where the user is not prompted to view SBOMs. This occurs because p.sbomViewFiles is not being populated correctly. This PR fixes this issue by populating p.sbomViewFiles.

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify

netlify Bot commented Mar 19, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 42a4d90
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65f9ca5cd51167000883794e

@lucasrod16 lucasrod16 self-assigned this Mar 19, 2024
@lucasrod16 lucasrod16 changed the title fix: populate p.sbomViewFiles on deploy and mirror fix: populate p.sbomViewFiles on deploy and mirror Mar 19, 2024
@lucasrod16
lucasrod16 marked this pull request as ready for review March 19, 2024 15:59
AustinAbro321
AustinAbro321 previously approved these changes Mar 19, 2024
View reviewed changes

@AustinAbro321 AustinAbro321 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Noxsios
Noxsios suggested changes Mar 19, 2024
View reviewed changes

@Noxsios Noxsios left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's throw a require.NotContains in the init package test (or in a test we know for sure must contains SBOMs) to ensure it always has SBOMs. Not a 100% great test, but should prevent this regression in the future.

@lucasrod16

lucasrod16 commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

let's throw a require.NotContains in the init package test (or in a test we know for sure must contains SBOMs) to ensure it always has SBOMs. Not a 100% great test, but should prevent this regression in the future.

Good call. Adding that now

@lucasrod16
lucasrod16 requested a review from Noxsios March 19, 2024 17:28
@Noxsios
Noxsios merged commit 6d2378d into main Mar 19, 2024
@Noxsios
Noxsios deleted the fix-sbomViewFiles-on-deploy branch March 19, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 left review comments
@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy
@Racer159 Racer159 Awaiting requested review from Racer159
+1 more reviewer
@Noxsios Noxsios Noxsios approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lucasrod16 lucasrod16

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucasrod16 @AustinAbro321 @Noxsios