Visitar URL original
Use dynamic editUrl for ecosystem docs by dancewithheart · Pull Request #10620 · zio/zio · GitHub
Skip to content

Use dynamic editUrl for ecosystem docs - #10620

Merged
khajavi merged 1 commit into
zio:series/2.xfrom
dancewithheart:fix-ecosystem-editurl-routing
Apr 4, 2026
Merged

khajavi merged 1 commit into
zio:series/2.xfrom
dancewithheart:fix-ecosystem-editurl-routing

Conversation

@dancewithheart

Copy link
Copy Markdown
Contributor

Fixes zio/zio-prelude#1350

Fix broken “Edit this page” links for ecosystem docs (e.g. zio-prelude, zio-kafka), which currently point to the zio/zio repository instead of their respective repositories.

Change

Replace the global docs.editUrl with a function that routes edit links
based on the top-level doc path (e.g. zio-prelude, zio-kafka),
while preserving existing behavior for core ZIO docs.

Testing

Verified editUrl inputs locally and confirmed correct URL generation.

I was not able to fully verify the website end-to-end due to unrelated
Docusaurus/Yarn build issues in my environment. Happy to adjust based on maintainer feedback or guidance on local setup.

@sideeffffect sideeffffect left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dancewithheart
dancewithheart marked this pull request as ready for review March 20, 2026 22:33
@dancewithheart

Copy link
Copy Markdown
Contributor Author

I added a small test (just using plain JS) — not sure if it’s worth including.
Maybe tests for generated docs are overkill here?

I’m not really a FE developer, so I might be going in the wrong direction :)

If anyone wants to jump in and help verify or improve this, that would be awesome!

@khajavi

khajavi commented Apr 4, 2026

Copy link
Copy Markdown
Member

@dancewithheart
Thanks for you contribution!

@khajavi
khajavi merged commit 62fc97e into zio:series/2.x Apr 4, 2026
20 checks passed
khajavi pushed a commit to khajavi/zio that referenced this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead «Edit this page» link on https://zio.dev/zio-prelude/

3 participants