Visitar URL original
chore: upgrade F# lang to 8.0 and Microsoft.Build.Tasks.Core to 18.3.3 by ScarletKuro · Pull Request #461 · AwesomeAssertions/AwesomeAssertions · GitHub
Skip to content

chore: upgrade F# lang to 8.0 and Microsoft.Build.Tasks.Core to 18.3.3 - #461

Merged
ScarletKuro merged 2 commits into
mainfrom
fsharp_update
Mar 13, 2026
Merged

ScarletKuro merged 2 commits into
mainfrom
fsharp_update

Conversation

@ScarletKuro

@ScarletKuro ScarletKuro commented Mar 13, 2026 •

Copy link
Copy Markdown
Contributor

There are two things got broken at same time:

  • 560fea8 FS3880: Language version '6.0' is out of support
  • b7a8171 MissingMethodException: Method not found: Void Microsoft.Build.Framework.IMetadataContainer.RemoveMetadataRange(System.Collections.Generic.IEnumerable1<System.Stri ng>). NUKE loads Microsoft.Build.Tasks.Core version 18.0.2, while the installed .NET SDK requires now a newer version.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Legal checklist

  • This work is entirely original, it is not derived from any existing code incompatible with the Apache 2.0 License, like FluentAssertions.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Mar 13, 2026 •

Copy link
Copy Markdown

Test Results

    75 files  +    75      75 suites  +75   3m 50s ⏱️ + 3m 50s
 6 296 tests + 6 296   6 296 ✅ + 6 296  0 💤 ±0  0 ❌ ±0 
58 459 runs  +58 459  58 459 ✅ +58 459  0 💤 ±0  0 ❌ ±0 

Results for commit b7a8171. ± Comparison against base commit aa97908.

♻️ This comment has been updated with latest results.

@cbersch

cbersch commented Mar 13, 2026

Copy link
Copy Markdown
Member

Thanks for fixing this. Any idea why the F# stuff broke out of the blue?

@ScarletKuro

Copy link
Copy Markdown
Contributor Author

Thanks for fixing this. Any idea why the F# stuff broke out of the blue?

No idea. It seems MSFT first added this in .NET 11, but it has now also appeared in the latest .NET 10 SDK.
When I had SDK 10.0.103 locally, the build passed just fine. After updating to 10.0.200, it started failing the same way as in CI.

@ScarletKuro
ScarletKuro merged commit 232bee3 into main Mar 13, 2026
14 checks passed
@ScarletKuro
ScarletKuro deleted the fsharp_update branch March 13, 2026 19:01
This was referenced Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants