Visitar URL original
Removing duplicate ForConditions() in two TypeAssertions methods by misirlou-tg · Pull Request #512 · AwesomeAssertions/AwesomeAssertions · GitHub
Skip to content

Removing duplicate ForConditions() in two TypeAssertions methods - #512

Merged
cbersch merged 1 commit into
AwesomeAssertions:mainfrom
misirlou-tg:remove-duplicate-for-conditions
Jun 15, 2026
Merged

cbersch merged 1 commit into
AwesomeAssertions:mainfrom
misirlou-tg:remove-duplicate-for-conditions

Conversation

@misirlou-tg

Copy link
Copy Markdown
Contributor

While researching the usages of AssertionChain.ForCondition() I came across these two usages where there were duplicate conditions in a chain.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Legal checklist

  • This work is entirely original, it is not derived from any existing code incompatible with the Apache 2.0 License, like FluentAssertions.

@sonarqubecloud

Copy link
Copy Markdown

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 27466893321

Coverage increased (+0.005%) to 96.71%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12904
Covered Lines: 12749
Line Coverage: 98.8%
Relevant Branches: 4028
Covered Branches: 3626
Branch Coverage: 90.02%
Branches in Coverage %: Yes
Coverage Strength: 39055.67 hits per line

💛 - Coveralls

@cbersch cbersch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@cbersch
cbersch merged commit 7ed52db into AwesomeAssertions:main Jun 15, 2026
8 checks passed
@misirlou-tg
misirlou-tg deleted the remove-duplicate-for-conditions branch June 15, 2026 12:28
This was referenced Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants