Visitar URL original
Add option ExcludingObsoleteMembers for structural comparison by lg2de · Pull Request #558 · AwesomeAssertions/AwesomeAssertions · GitHub
Skip to content

Add option ExcludingObsoleteMembers for structural comparison - #558

Merged
lg2de merged 11 commits into
AwesomeAssertions:mainfrom
lg2de:ignoring-obsolete
Jul 27, 2026
Merged

Add option ExcludingObsoleteMembers for structural comparison#558
lg2de merged 11 commits into
AwesomeAssertions:mainfrom
lg2de:ignoring-obsolete

Conversation

@lg2de

@lg2de lg2de commented Jul 25, 2026

Copy link
Copy Markdown
Member

Fixed #505

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Legal checklist

  • This work is entirely original, it is not derived from any existing code incompatible with the Apache 2.0 License, like FluentAssertions.

lg2de
lg2de commented Jul 25, 2026
View reviewed changes
Comment thread docs/_pages/releases.md Resolved
@lg2de lg2de changed the title Ignoring obsolete Add option ExcludingObsoleteMembers for structural comparison Jul 25, 2026
@lg2de lg2de added the feature New feature label Jul 25, 2026
@coveralls

coveralls commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report for CI Build 30220053798

Coverage increased (+0.004%) to 96.719%

Details

  • Coverage increased (+0.004%) from the base build.
  • Patch coverage: 13 of 13 lines across 5 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 12931
Covered Lines: 12779
Line Coverage: 98.82%
Relevant Branches: 4044
Covered Branches: 3639
Branch Coverage: 89.99%
Branches in Coverage %: Yes
Coverage Strength: 60759.67 hits per line
💛 - Coveralls

@lg2de

lg2de commented Jul 25, 2026

Copy link
Copy Markdown
Member Author

@AwesomeAssertions/collaborators , I do not know how to cover ExcludeObsoleteMembersRule.IncludesMembers. It seems to be used only a rare cases.
The same member in ExcludeNonBrowsableMembersRule is also not covered.
Is it as interface member the correct abstraction?

@lg2de
lg2de force-pushed the ignoring-obsolete branch from c000e17 to 615d2a0 Compare July 26, 2026 09:36
cbersch
cbersch reviewed Jul 26, 2026
View reviewed changes
Comment thread Tests/AwesomeAssertions.Equivalency.Specs/SelectionRulesSpecs.Obsolete.cs Resolved
Comment thread Tests/AwesomeAssertions.Equivalency.Specs/SelectionRulesSpecs.Obsolete.cs Resolved
@lg2de

lg2de commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Is it as interface member the correct abstraction?

-After additional analysis I'm quite sure that the abstraction is not (fully) correct. The member IncludesMembers is not used for this kind of rules. (I'll make a separate issue for detailed discussion.)
As the same member in ExcludeNonBrowsableMembersRule is also not covered, I want to ignore this missing coverage and hope you agree.-

Even, there seems to be a defect on the interface, I managed to fix the coverage.

@sonarqubecloud

sonarqubecloud Bot commented Jul 26, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lg2de
lg2de requested a review from a team July 26, 2026 21:09
@lg2de
lg2de merged commit f310525 into AwesomeAssertions:main Jul 27, 2026
8 checks passed
@lg2de
lg2de deleted the ignoring-obsolete branch July 27, 2026 08:55
@lg2de lg2de mentioned this pull request Jul 27, 2026
Merged
1 task done
This was referenced Aug 20, 2026
Closed
Closed
Merged
Merged
Merged
This was referenced Nov 2, 2026
Open
Closed
Open
Merged
Merged
Open
Closed
Open
Open
This was referenced Nov 9, 2026
Open
Open
Open
Open
Closed
Closed
Closed
Closed
Open
Closed
Closed
Open
Closed
Open
Closed
Closed
Open
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbersch cbersch cbersch approved these changes

Assignees

No one assigned

Labels

feature New feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ExcludeObsoleteMembers to IEquivalencyOptions

3 participants

@lg2de @coveralls @cbersch