Visitar URL original
Add ignoreAnnotatedFunctions to TooManyFunctions by matejdro · Pull Request #6875 · detekt/detekt · GitHub
Skip to content

Add ignoreAnnotatedFunctions to TooManyFunctions - #6875

Merged
BraisGabin merged 5 commits into
detekt:mainfrom
matejdro:too-many-functions-annotation
Jan 26, 2024
Merged

Add ignoreAnnotatedFunctions to TooManyFunctions#6875
BraisGabin merged 5 commits into
detekt:mainfrom
matejdro:too-many-functions-annotation

Conversation

@matejdro

@matejdro matejdro commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

This fixes #6516

@codecov

codecov Bot commented Jan 16, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (109a55d) 84.12% compared to head (acea218) 84.12%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6875   +/-   ##
=========================================
  Coverage     84.12%   84.12%           
+ Complexity     3932     3928    -4     
=========================================
  Files           577      577           
  Lines         13180    13180           
  Branches       2488     2489    +1     
=========================================
  Hits          11088    11088           
  Misses          851      851           
  Partials       1241     1241

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cortinico
cortinico reviewed Jan 16, 2024
View reviewed changes
Comment thread ...-complexity/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/TooManyFunctions.kt
atulgpt
atulgpt reviewed Jan 16, 2024
View reviewed changes
Comment thread ...-complexity/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/TooManyFunctions.kt
@detekt-ci

detekt-ci commented Jan 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
Warnings
⚠️

It looks like you're editing the un-versioned copy of our website. This affects only users on the 'next' version of detekt, and it's correct only if you intend to document a future change or feature. If you intended to make a change also for the current version of detekt, please make sure you edit the equivalent file inside website/versioned_docs/ as well.
Messages
📖

Thank you very much for making our website better ❤️!

Generated by 🚫 dangerJS against acea218

github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 16, 2024
View reviewed changes
Comment thread ...-complexity/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/complexity/TooManyFunctions.kt Fixed
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Jan 26, 2024
@BraisGabin BraisGabin added this to the 2.0.0 milestone Jan 26, 2024
@BraisGabin
BraisGabin merged commit 1475363 into detekt:main Jan 26, 2024
cortinico
cortinico reviewed Jan 27, 2024
View reviewed changes
Comment thread website/docs/introduction/compose.md
#### Recommended configuration

* Set `ignoreAnnotated` to `['Preview']`
*

@cortinico cortinico Jan 27, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This * should be removed

@matejdro
matejdro deleted the too-many-functions-annotation branch January 29, 2024 06:18
cortinico pushed a commit that referenced this pull request Jan 31, 2024
@matejdro @cortinico
Add ignoreAnnotatedFunctions to TooManyFunctions (#6875)
210920a 
* Add ignoreAnnotatedFunctions to TooManyFunctions

* Add TooManyFunctions recommendation to compose docs

* Ensure Preview annotation in tests is declared

* Simplify hasAnnotation check

* Revert "Simplify hasAnnotation check"

This reverts commit 3d16e57.
cortinico pushed a commit that referenced this pull request Jan 31, 2024
@matejdro @cortinico
Add ignoreAnnotatedFunctions to TooManyFunctions (#6875)
a5d135f 
* Add ignoreAnnotatedFunctions to TooManyFunctions

* Add TooManyFunctions recommendation to compose docs

* Ensure Preview annotation in tests is declared

* Simplify hasAnnotation check

* Revert "Simplify hasAnnotation check"

This reverts commit 3d16e57.
cortinico pushed a commit that referenced this pull request Jan 31, 2024
@matejdro @cortinico
Add ignoreAnnotatedFunctions to TooManyFunctions (#6875)
e44aff7 
* Add ignoreAnnotatedFunctions to TooManyFunctions

* Add TooManyFunctions recommendation to compose docs

* Ensure Preview annotation in tests is declared

* Simplify hasAnnotation check

* Revert "Simplify hasAnnotation check"

This reverts commit 3d16e57.
@BraisGabin BraisGabin mentioned this pull request Feb 2, 2024
Merged

This branch was successfully deployed

1 active deployment
Preview — acea2181 Deployed Jan 16, 2024 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico left review comments
@BraisGabin BraisGabin BraisGabin approved these changes
+1 more reviewer
@atulgpt atulgpt atulgpt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation pick request Marker for PRs that should be ported to the 1.0 release branch rules

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Add ignoreAnnotatedFunctions to TooManyFunctions

6 participants

@matejdro @detekt-ci @BraisGabin @cortinico @atulgpt @github-advanced-security