Visitar URL original
Check for root of receiver in selector expression by atulgpt · Pull Request #7220 · detekt/detekt · GitHub
Skip to content

Check for root of receiver in selector expression - #7220

Merged
BraisGabin merged 1 commit into
detekt:mainfrom
atulgpt:fixes/6373/nested-nullable-property
Jul 28, 2024
Merged

BraisGabin merged 1 commit into
detekt:mainfrom
atulgpt:fixes/6373/nested-nullable-property

Conversation

@atulgpt

@atulgpt atulgpt commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

Fixes #6373

@codecov

codecov Bot commented Apr 23, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@f1b1bb1). Click here to learn what that means.

Files Patch % Lines
...ch/detekt/rules/bugs/NullCheckOnMutableProperty.kt 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7220   +/-   ##
=======================================
  Coverage        ?   84.80%           
  Complexity      ?     3998           
=======================================
  Files           ?      577           
  Lines           ?    12128           
  Branches        ?     2485           
=======================================
  Hits            ?    10285           
  Misses          ?      616           
  Partials        ?     1227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atulgpt
atulgpt force-pushed the fixes/6373/nested-nullable-property branch from 523f846 to 86a045c Compare May 7, 2024 10:00
@atulgpt
atulgpt requested a review from cortinico May 7, 2024 10:01

@cortinico cortinico left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 sorry for the late reply.

@BraisGabin
BraisGabin merged commit 2132768 into detekt:main Jul 28, 2024
@detekt-ci

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against 86a045c

@BraisGabin BraisGabin added this to the 2.0.0 milestone Jul 28, 2024
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Jul 28, 2024
@atulgpt
atulgpt deleted the fixes/6373/nested-nullable-property branch July 29, 2024 14:02

This branch was successfully deployed

1 active deployment
Preview — 86a045c5 Deployed May 7, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pick request Marker for PRs that should be ported to the 1.0 release branch rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False negative on UnnecessaryLet in nested nullable property

4 participants