Visitar URL original
docs: document every permission type passed to the session permission handlers by trop[bot] · Pull Request #53212 · electron/electron · GitHub
Skip to content

docs: document every permission type passed to the session permission handlers - #53212

Merged
MarshallOfSound merged 1 commit into
44-x-yfrom
trop/44-x-y-bp-docs-document-every-permission-type-passed-to-the-session-permission-handlers-1787769140007
Aug 26, 2026
Merged

MarshallOfSound merged 1 commit into
44-x-yfrom
trop/44-x-y-bp-docs-document-every-permission-type-passed-to-the-session-permission-handlers-1787769140007

Conversation

@trop

@trop trop Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Backport of #53170

See that PR for details.

Notes: Documented every permission type that can be passed to ses.setPermissionRequestHandler() and ses.setPermissionCheckHandler(), and added them to the TypeScript definitions.

… handlers

Both ses.setPermissionRequestHandler() and ses.setPermissionCheckHandler() receive every blink::PermissionType that Chromium asks about; nothing is filtered before the JS handler runs. The docs (and therefore the generated TypeScript union) only listed 20 of the 46 strings the converter can emit, so values such as screen-wake-lock, sensors or persistent-storage were undocumented and failed type-checking.

List all 46 values for both handlers, in alphabetical order, and note that the list mirrors Chromium's permission types.

Co-authored-by: Sam Attard <sattard@anthropic.com>
@trop
trop Bot requested a review from MarshallOfSound August 26, 2026 18:32
@trop trop Bot added 44-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 26, 2026
@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) August 26, 2026 18:41
@MarshallOfSound
MarshallOfSound merged commit 28a7a7f into 44-x-y Aug 26, 2026
62 checks passed
@MarshallOfSound
MarshallOfSound deleted the trop/44-x-y-bp-docs-document-every-permission-type-passed-to-the-session-permission-handlers-1787769140007 branch August 26, 2026 18:54
@release-clerk

release-clerk Bot commented Aug 26, 2026

Copy link
Copy Markdown

Release Notes Persisted

Documented every permission type that can be passed to ses.setPermissionRequestHandler() and ses.setPermissionCheckHandler(), and added them to the TypeScript definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

44-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant