Visitar URL original
C++: introduce automatic installation of dependencies in the autobuilder by redsun82 · Pull Request #1889 · github/codeql-action · GitHub
Skip to content

C++: introduce automatic installation of dependencies in the autobuilder - #1889

Merged
redsun82 merged 6 commits into
mainfrom
redsun82/cpp-autoinstall-dependencies
Sep 21, 2023
Merged

C++: introduce automatic installation of dependencies in the autobuilder#1889
redsun82 merged 6 commits into
mainfrom
redsun82/cpp-autoinstall-dependencies

Conversation

@redsun82

@redsun82 redsun82 commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This introduces the possibility to automatically install dependencies when running the C++ autobuilder on an Ubuntu runner, that will be available with upcoming version 2.15.0. This behaviour can be explicitly requested by setting CODEQL_EXTRACTOR_CPP_AUTOINSTALL_DEPENDENCIES in the autobuild action env, or is otherwise driven by the code_scanning_cpp_dependency_installation feature flag.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@redsun82
redsun82 force-pushed the redsun82/cpp-autoinstall-dependencies branch from 242362a to 1dc6288 Compare September 18, 2023 09:00
github-advanced-security[bot]
github-advanced-security AI found potential problems Sep 18, 2023
View reviewed changes
Comment thread src/autobuild.ts Resolved
henrymercer
henrymercer reviewed Sep 18, 2023
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will do the right thing, though I have a couple of questions about whether we can simplify the experience by reducing the amount of configuration options. Let me know what you think!

Comment thread autobuild/action.yml Resolved
Comment thread src/autobuild.ts Resolved
Comment thread src/autobuild.ts Resolved
Comment thread src/feature-flags.ts Resolved
Comment thread src/autobuild.ts Resolved
github-advanced-security[bot]
github-advanced-security AI found potential problems Sep 20, 2023
View reviewed changes
Comment thread src/autobuild.ts Fixed
@redsun82
C++: introduce automatic installation of dependencies in the autobuilder
c4c0678 
This introduces the possibility to automatically install dependencies
when running the C++ autobuilder on an Ubuntu runner, that will be
available with upcoming version 2.15.0.

An experimental `cpp-autoinstall-dependencies` input is added to the
`autobuild` action. When not set, the default is driven by a feature
flag.
@redsun82
C++: simplify CppDependencyInstallation interface
bf21875
@redsun82
Add RUNNER_ENVIRONMENT to the list of known default setup variables
765807b
@redsun82
redsun82 force-pushed the redsun82/cpp-autoinstall-dependencies branch from 6de7ce6 to 765807b Compare September 20, 2023 12:08
@redsun82
redsun82 marked this pull request as ready for review September 20, 2023 13:51
@redsun82
redsun82 requested a review from a team as a code owner September 20, 2023 13:52
henrymercer
henrymercer previously approved these changes Sep 21, 2023
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions around logging, but LGTM otherwise!

Comment thread src/autobuild.ts Resolved
Comment thread src/autobuild.ts Resolved
Comment thread src/autobuild.ts Resolved
@redsun82 @henrymercer
Apply suggestions from code review
53bed11 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@redsun82
redsun82 enabled auto-merge September 21, 2023 14:11
henrymercer
henrymercer approved these changes Sep 21, 2023
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@redsun82
redsun82 merged commit 49aaa9a into main Sep 21, 2023
@redsun82
redsun82 deleted the redsun82/cpp-autoinstall-dependencies branch September 21, 2023 14:49
@github-actions github-actions Bot mentioned this pull request Sep 27, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@redsun82 @henrymercer @github-advanced-security