Visitar URL original
Add feature to enable Java network debugging by mbg · Pull Request #3485 · github/codeql-action · GitHub
Skip to content

Add feature to enable Java network debugging - #3485

Merged
mbg merged 4 commits into
mainfrom
mbg/java/network-debugging
Feb 17, 2026
Merged

Add feature to enable Java network debugging#3485
mbg merged 4 commits into
mainfrom
mbg/java/network-debugging

Conversation

@mbg

@mbg mbg commented Feb 15, 2026

Copy link
Copy Markdown
Member

Adds a FF to enable Java network debugging for the rest of the job.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, CCR, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • CCR - The changes impact analyses for Copilot Code Reviews.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Test repository - This change will be tested on a test repository before merging.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Feb 15, 2026
@github-actions github-actions Bot added the size/XS Should be very easy to review label Feb 15, 2026
esbena
esbena reviewed Feb 16, 2026
View reviewed changes

@esbena esbena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early comment

Comment thread src/init-action.ts Resolved
@mbg
mbg marked this pull request as ready for review February 17, 2026 09:55
@mbg
mbg requested a review from a team as a code owner February 17, 2026 09:55
@mbg
mbg requested review from Copilot and esbena February 17, 2026 09:55
Copilot AI reviewed Feb 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new feature flag to enable Java TLS/network debug logging for the remainder of a workflow job by appending -Djavax.net.debug=all to JAVA_TOOL_OPTIONS during init.

Changes:

  • Introduces Feature.JavaNetworkDebugging and its env var configuration (CODEQL_ACTION_JAVA_NETWORK_DEBUGGING).
  • When the feature is enabled, updates JAVA_TOOL_OPTIONS in init-action to enable Java network debugging.
  • Regenerates compiled lib/ outputs to reflect the TypeScript changes.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

File Description
src/init-action.ts Exports JAVA_TOOL_OPTIONS with -Djavax.net.debug=all when the new feature flag is enabled.
src/feature-flags.ts Adds the JavaNetworkDebugging feature and its featureConfig entry.
lib/*.js Generated build output reflecting the feature flag/config and init behavior updates.

Comment thread src/init-action.ts Resolved
Comment thread src/init-action.ts Resolved
@mbg
mbg enabled auto-merge February 17, 2026 10:03
@mbg
mbg merged commit ebce69a into main Feb 17, 2026
296 of 499 checks passed
@mbg
mbg deleted the mbg/java/network-debugging branch February 17, 2026 10:19
This was referenced Feb 20, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@esbena esbena esbena approved these changes

Assignees

@mbg mbg

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbg @esbena