Visitar URL original
fix: resolve relative PATH entries against the provided cwd by RSS1102 · Pull Request #128 · harryfei/which-rs · GitHub
Skip to content

fix: resolve relative PATH entries against the provided cwd - #128

Merged
Xaeroxe merged 1 commit into
harryfei:masterfrom
RSS1102:rss1102/resolve-relative-path-cwd
Aug 26, 2026
Merged

Xaeroxe merged 1 commit into
harryfei:masterfrom
RSS1102:rss1102/resolve-relative-path-cwd

Conversation

@RSS1102

@RSS1102 RSS1102 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve ordinary relative PATH entries against the cwd supplied to which_in
  • preserve tilde expansion and Windows drive-relative, root-relative, absolute, and UNC path semantics
  • preserve platform-specific empty PATH behavior while using Sys::is_windows for custom system implementations
  • add regression tests for tools, ./tools, ../tools, Unix cwd values containing :, empty PATH entries, and Windows-special path classification

Tests

  • cargo test --workspace --all-features -- --include-ignored
  • cargo test --workspace --no-default-features
  • cargo clippy --workspace --all-targets --all-features -- -Dwarnings
  • cargo fmt --all -- --check

Fixes #127

@RSS1102 RSS1102 changed the title Resolve relative PATH entries against provided cwd Fix relative PATH entry resolution with a provided cwd Aug 17, 2026
@RSS1102 RSS1102 changed the title Fix relative PATH entry resolution with a provided cwd fix: resolve relative PATH entries against the provided cwd Aug 17, 2026

@Xaeroxe Xaeroxe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your bug fix!

@Xaeroxe
Xaeroxe merged commit 48e49d5 into harryfei:master Aug 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve relative PATH entries against the cwd passed to which_in

2 participants