Visitar URL original
registry: use symlink_bins in ibmcloud by dnwe · Pull Request #9685 · jdx/mise · GitHub
Skip to content

registry: use symlink_bins in ibmcloud - #9685

Merged
jdx merged 1 commit into
jdx:mainfrom
dnwe:ibmcloud
May 8, 2026
Merged

jdx merged 1 commit into
jdx:mainfrom
dnwe:ibmcloud

Conversation

@dnwe

@dnwe dnwe commented May 7, 2026 •

Copy link
Copy Markdown
Contributor

mise currently puts the whole folder on the $PATH so that inadvertently ends up shadowing /usr/bin/install with the 'install' binary from ibmcloud. Use symlink_bins so that only the ibmcloud binary ends up on the $PATH

@greptile-apps

greptile-apps Bot commented May 7, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Fixes the ibmcloud backend so that only actual CLI binaries are exposed on $PATH, preventing extra scripts bundled in the release archive from shadowing system commands like /usr/bin/install. This mirrors the same symlink_bins = "true" option already used by registry/aws-cli.toml and registry/aws-sam.toml.

  • Switches the backends entry from a plain string to the inline-table form to attach options = { symlink_bins = "true" }, directing the aqua backend to create a .mise-bins directory containing only symlinks to the declared binaries, and to use that directory as the sole $PATH entry.

Confidence Score: 5/5

Safe to merge — the change is a one-line config addition that follows a well-established pattern in this repository.

The change is a minimal, targeted config update to registry/ibmcloud.toml, adding symlink_bins = "true" to the aqua backend entry. The same option is already used and tested for aws-cli and aws-sam, and the underlying symlink_bins logic in aqua.rs has existing unit/e2e test coverage. There are no logic changes, no new code paths, and no risk of regressions elsewhere.

No files require special attention.

Reviews (3): Last reviewed commit: "registry: use symlink_bins in ibmcloud" | Re-trigger Greptile

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ibmcloud registry configuration to include a postinstall script for removing unnecessary installation files on Unix systems. Feedback suggests using the more idiomatic symlink_bins = "true" option instead of a shell script to handle binary management more robustly.

Comment thread registry/ibmcloud.toml Resolved
mise currently puts the whole folder on the $PATH so that inadvertently
ends up shadowing /usr/bin/install with the 'install' binary from
ibmcloud. Use symlink_bins so that only the `ibmcloud` binary ends up on
the $PATH

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@dnwe dnwe changed the title registry: remove leftover scripts from ibmcloud registry: use symlink_bins in ibmcloud May 7, 2026
@jdx
jdx merged commit 144db90 into jdx:main May 8, 2026
37 checks passed
mise-en-dev added a commit that referenced this pull request May 9, 2026
### 🚀 Features

- **(java)** remove musl feature in favor of autom. musl detection and
alpine-linux versions by @roele in
[#9688](#9688)

### 🚜 Refactor

- **(schema)** stop patching task_template in render script by @risu729
in [#9680](#9680)

### 📚 Documentation

- **(deps)** drop codegen example from configuration section by @jdx in
[6b2d851](6b2d851)

### ⚡ Performance

- avoid spawning process to set exit code by @vemoo in
[#9723](#9723)

### 📦️ Dependency Updates

- update ghcr.io/jdx/mise:rpm docker digest to b8b0b72 by @renovate[bot]
in [#9711](#9711)
- update ghcr.io/jdx/mise:alpine docker digest to f130900 by
@renovate[bot] in [#9709](#9709)
- update ghcr.io/jdx/mise:deb docker digest to 71bda11 by @renovate[bot]
in [#9710](#9710)
- bump rattler crates together by @jdx in
[#9721](#9721)
- update rust crate junction to v2 by @renovate[bot] in
[#9726](#9726)
- update rust docker digest to 4d4ec51 by @renovate[bot] in
[#9734](#9734)

### 📦 Registry

- use symlink_bins in ibmcloud by @dnwe in
[#9685](#9685)

### Chore

- **(ci)** pass mise github token to tests by @risu729 in
[#9684](#9684)

## 📦 Aqua Registry Updates

### New Packages (2)

-
[`DataDog/managed-kubernetes-auditing-toolkit`](https://github.com/DataDog/managed-kubernetes-auditing-toolkit)
- `oracle.com/sqlcl`

### Updated Packages (3)

-
[`alltuner/mise-completions-sync`](https://github.com/alltuner/mise-completions-sync)
- [`iann0036/iamlive`](https://github.com/iann0036/iamlive)
- [`pnpm/pnpm`](https://github.com/pnpm/pnpm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants