Visitar URL original
Build just once when tfms run in parallel by nohwnd · Pull Request #15465 · microsoft/vstest · GitHub
Skip to content

Build just once when tfms run in parallel - #15465

Merged
Jakub Jareš (nohwnd) merged 2 commits into
microsoft:mainfrom
nohwnd:build-only-once-even-in-dotnet-test-parallel
Mar 10, 2026
Merged

Build just once when tfms run in parallel#15465
Jakub Jareš (nohwnd) merged 2 commits into
microsoft:mainfrom
nohwnd:build-only-once-even-in-dotnet-test-parallel

Conversation

@nohwnd

@nohwnd Jakub Jareš (nohwnd) commented Mar 9, 2026

Copy link
Copy Markdown
Member

Description

Running dotnet test would trigger build of assets from two places at the same time, which does more work, and also fails occasionally when they run into each other.

Related issue

Fix #15453

Copilot AI review requested due to automatic review settings March 9, 2026 16:24
Copilot AI reviewed Mar 9, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents parallel dotnet test runs (across TFMs) from rebuilding/patching the same test assets concurrently by introducing a named mutex guarding the one-time build/setup work.

Changes:

  • Added a named Mutex to serialize build/setup across parallel test runs within the same repo clone.
  • Moved build/setup steps (unzip, cache cleanup, asset builds, dotnet patching) behind the mutex.
  • Added a timeout path for waiting test runs.

Comment thread test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Build.cs Resolved
Comment thread test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Build.cs Resolved
Comment thread test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Build.cs Resolved
@nohwnd
Jakub Jareš (nohwnd) enabled auto-merge (squash) March 10, 2026 07:41
@nohwnd
Jakub Jareš (nohwnd) merged commit 9d41bec into microsoft:main Mar 10, 2026
6 checks passed
This was referenced May 26, 2026
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
This was referenced Nov 11, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Closed
Open
Merged
Open
Open
Open
Merged
Closed
Open
Open
Open
Open
Closed
Open
Open
Open
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Evangelink Amaury Levé (Evangelink) Evangelink approved these changes
+1 more reviewer
@Youssef1313 Youssef Fahmy (Youssef1313) Youssef1313 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Running dotnet test on integration tests will run Build (the method) on both

4 participants

@nohwnd @Evangelink @Youssef1313