Visitar URL original
[locale] change abbreviation of august for Indonesian locale by ardhyanth · Pull Request #6197 · moment/moment · GitHub
Skip to content

[locale] change abbreviation of august for Indonesian locale - #6197

Merged
mattjohnsonpint merged 2 commits into
moment:developfrom
ardhyanth:develop
Aug 18, 2026
Merged

mattjohnsonpint merged 2 commits into
moment:developfrom
ardhyanth:develop

Conversation

@ardhyanth

Copy link
Copy Markdown
Contributor

the latest standard of abbreviation for August in Indonesian is "Agu" instead of "Agt",

reference: https://www.unicode.org/cldr/charts/44/summary/id.html#3cb5a7caab50ce56

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jan 4, 2024 •

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ardhyanth / name: Rahmadani Ardhyanto (dc2ef37)

@ardhyanth ardhyanth closed this Jan 4, 2024
@ardhyanth ardhyanth reopened this Jan 4, 2024
@aryomuzakki

Copy link
Copy Markdown

This should be simple

@mattjohnsonpint mattjohnsonpint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this correction! I’m using AI to assist with this review because I’m not a native Indonesian speaker, so I checked the proposal against external sources rather than relying on my own language knowledge.

The formatting change from Agt to Agu looks correct:

I noticed one compatibility issue with parsing. Existing Moment releases accept Agt, but this change would make it invalid. For example:

moment('Agt', 'MMM', 'id', true).isValid(); // currently true

Could you keep Agt as a parsing alias while changing formatted output to Agu? I would also like the parsing tests to cover both the preferred Agu form and the legacy Agt form.

Please also remove the generated changes under dist/, locale/, and min/, then commit those updates and rebase the PR on the latest develop branch. Only src/locale/id.js and src/test/locale/id.js should remain in the PR; generated files are updated as part of the release process.

Thanks again. The core correction is well-supported, and preserving the old parsing form should make it safe for existing users.

@mattjohnsonpint

Copy link
Copy Markdown
Contributor

On second thought, since the grammar is correct and the required changes are largely mechanical, I can finish this out myself.

@mattjohnsonpint
mattjohnsonpint merged commit 7401a0b into moment:develop Aug 18, 2026
19 checks passed
@mattjohnsonpint mattjohnsonpint added this to the 2.31.0 milestone Aug 18, 2026
alexandroit pushed a commit to alexandroit/moment that referenced this pull request Aug 20, 2026
…6197)

Co-authored-by: Matt Johnson-Pint <mattjohnsonpint@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants