Visitar URL original
pass meter provider to avoid using the global otel instance by zeitlinger · Pull Request #7475 · open-telemetry/opentelemetry-java · GitHub
Skip to content

pass meter provider to avoid using the global otel instance - #7475

Merged
jkwatson merged 6 commits into
open-telemetry:mainfrom
zeitlinger:declarative-config-meter-provider
Sep 4, 2025
Merged

pass meter provider to avoid using the global otel instance#7475
jkwatson merged 6 commits into
open-telemetry:mainfrom
zeitlinger:declarative-config-meter-provider

Conversation

@zeitlinger

@zeitlinger zeitlinger commented Jul 8, 2025

Copy link
Copy Markdown
Member

Fixes #7435

@zeitlinger
zeitlinger requested a review from a team as a code owner July 8, 2025 14:48
@zeitlinger zeitlinger self-assigned this Jul 8, 2025
@codecov

codecov Bot commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (5186238) to head (89b58c8).
⚠️ Report is 107 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7475      +/-   ##
============================================
+ Coverage     89.82%   90.00%   +0.18%     
- Complexity     6999     7084      +85     
============================================
  Files           798      803       +5     
  Lines         21199    21421     +222     
  Branches       2055     2088      +33     
============================================
+ Hits          19042    19281     +239     
+ Misses         1496     1478      -18     
- Partials        661      662       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zeitlinger

zeitlinger commented Jul 9, 2025

Copy link
Copy Markdown
Member Author

@jack-berg please have a look 😄

jack-berg
jack-berg reviewed Jul 10, 2025
View reviewed changes
Comment thread .../src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/SpanProcessorFactory.java Resolved
jkwatson
jkwatson reviewed Jul 14, 2025
View reviewed changes
Comment thread .../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java Resolved
jkwatson
jkwatson reviewed Jul 14, 2025
View reviewed changes
Comment thread .../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java Resolved
robsunday
robsunday reviewed Jul 22, 2025
View reviewed changes
Comment thread ...a/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactory.java Resolved
Comment thread ...a/io/opentelemetry/sdk/extension/incubator/fileconfig/OpenTelemetryConfigurationFactory.java Resolved
@zeitlinger

zeitlinger commented Aug 15, 2025

Copy link
Copy Markdown
Member Author

@robsunday @jkwatson please check again

1 similar comment
@zeitlinger

zeitlinger commented Sep 1, 2025

Copy link
Copy Markdown
Member Author

@robsunday @jkwatson please check again

trask
trask reviewed Sep 4, 2025
View reviewed changes
Comment thread .../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java Resolved
trask
trask reviewed Sep 4, 2025
View reviewed changes
Comment thread .../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigContext.java Resolved
@zeitlinger

zeitlinger commented Sep 4, 2025

Copy link
Copy Markdown
Member Author

@jkwatson volatile added - please check again 😄

jkwatson
jkwatson approved these changes Sep 4, 2025
View reviewed changes

@jkwatson jkwatson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And, if Jack hates this, we still can change it, since it's not stable yet.

@jkwatson
jkwatson merged commit b18583a into open-telemetry:main Sep 4, 2025
@zeitlinger
zeitlinger deleted the declarative-config-meter-provider branch September 4, 2025 17:05
@zeitlinger

zeitlinger commented Sep 4, 2025

Copy link
Copy Markdown
Member Author

Thanks! And, if Jack hates this, we still can change it, since it's not stable yet.

👍

@zeitlinger zeitlinger mentioned this pull request Sep 17, 2025
Merged
the-clam pushed a commit to the-clam/opentelemetry-java that referenced this pull request Nov 6, 2025
@zeitlinger @the-clam
pass meter provider to avoid using the global otel instance (open-tel…
602cc6c 
…emetry#7475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask left review comments
@jack-berg jack-berg jack-berg left review comments
@jkwatson jkwatson jkwatson approved these changes
+1 more reviewer
@robsunday robsunday robsunday approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@zeitlinger zeitlinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Internal telemetry always uses GlobalOpenTelemetry when declarative config is used

5 participants

@zeitlinger @trask @jkwatson @jack-berg @robsunday