Visitar URL original
ci: use pnpm 11 for `pr-check` by jamietanna · Pull Request #284 · pnpm/action-setup · GitHub
Skip to content

ci: use pnpm 11 for pr-check - #284

Merged
zkochan merged 1 commit into
pnpm:masterfrom
jamietanna:ci/bump
Aug 3, 2026
Merged

zkochan merged 1 commit into
pnpm:masterfrom
jamietanna:ci/bump

Conversation

@jamietanna

@jamietanna jamietanna commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Noticed while working on #283.

Summary by CodeRabbit

  • Chores
    • Updated the build validation environment to use pnpm version 11, ensuring distribution checks run with the latest configured package manager version.

Noticed while working on pnpm#283.
@jamietanna
jamietanna requested a review from zkochan as a code owner August 3, 2026 08:54
@jamietanna jamietanna mentioned this pull request Aug 3, 2026
2 tasks done
@jamietanna

Copy link
Copy Markdown
Contributor Author

(I see there's a renovate.json but the repo isn't installed on the Renovate app - if you add it, you'll get automagic bumps for this, too!)

@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ec1c6b2-ebf5-453d-9a69-e58ec56c36f5

📥 Commits

Reviewing files that changed from the base of the PR and between 769ae71 and 8a0787d.

📒 Files selected for processing (1)
  • .github/workflows/pr-check.yaml
📜 Recent review details
🔇 Additional comments (1)
.github/workflows/pr-check.yaml (1)

22-22: LGTM!


📝 Walkthrough

Walkthrough

The pull request workflow now sets up pnpm version 11 before building and checking dist/index.js.

Changes

CI workflow

Layer / File(s) Summary
Update pnpm setup version
.github/workflows/pr-check.yaml
The workflow changes the pnpm setup action from version 9 to version 11.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: zkochan

Poem

A bunny checks the workflow line,
“pnpm eleven now will shine.”
The build hops on, the checks run bright,
With fresh tooling set just right.
One small change, a cleaner flight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely states that the pr-check CI workflow now uses pnpm 11.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

CI: bump pnpm to v11 in pr-check workflow

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Update pr-check GitHub Actions workflow to install pnpm v11.
• Reduce CI/tooling drift when building and verifying dist artifacts.
High-Level Assessment

The following are alternative approaches to this PR:

1. Use Corepack with packageManager from package.json
  • ➕ Single source of truth for pnpm version across local dev and CI
  • ➕ Avoids needing to update workflow when pnpm version changes
  • ➖ Requires ensuring Corepack is enabled and supported in the runner image
  • ➖ Still may need explicit Node/Corepack setup steps depending on environment
2. Pin pnpm via .npmrc/.tool-versions (asdf) and reference in CI
  • ➕ Centralizes tool versions outside workflow files
  • ➕ Easier multi-tool version management if the repo standardizes on one approach
  • ➖ Adds another config convention/tooling dependency
  • ➖ Still needs CI wiring to read/apply the version

Recommendation: The current approach (explicitly pinning pnpm in the workflow) is the simplest and lowest-risk for an immediate CI fix. If pnpm version changes are expected to be frequent, consider moving version ownership to package.json via Corepack to reduce duplication and drift.

Files changed (1) +1 / -1

Other (1) +1 / -1
pr-check.yamlBump pnpm version from 9 to 11 for pr-check +1/-1

Bump pnpm version from 9 to 11 for pr-check

• Updates the pnpm/action-setup step to install pnpm v11 instead of v9. This ensures the build step runs with the intended pnpm major version in CI.

.github/workflows/pr-check.yaml

@zkochan
zkochan merged commit 75677f7 into pnpm:master Aug 3, 2026
21 checks passed
dbmikus pushed a commit to gofixpoint/amika that referenced this pull request Oct 23, 2026
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 5.0.0 to 6.1.0.

## Release notes

Sourced from pnpm/action-setup's releases.

### v6.1.0

### What's Changed
- feat: support pnpm v12 by `@zkochan` in pnpm/action-setup#288

Full Changelog: pnpm/action-setup@v6.0.10...v6.1.0

### v6.0.10

### What's Changed
- docs(README): point users to the successor pnpm/setup action by `@BlackHole1` in pnpm/action-setup#282
- refactor: introduce restore keys for cache by `@SukkaW` in pnpm/action-setup#280
- ci: use pnpm 11 for `pr-check` by `@jamietanna` in pnpm/action-setup#284
- fix: update pnpm to v11.19.0 by `@jamietanna` in pnpm/action-setup#283
- docs: update README to include devEngines.packageManager by `@nemchik` in pnpm/action-setup#273

### New Contributors
- `@jamietanna` made their first contribution in pnpm/action-setup#284
- `@nemchik` made their first contribution in pnpm/action-setup#273

Full Changelog: pnpm/action-setup@v6...v6.0.10

### v6.0.9

### What's Changed
- fix: update pnpm to v11.7.0 by `@zkochan` in pnpm/action-setup#267

Full Changelog: pnpm/action-setup@v6...v6.0.9

### v6.0.8

### What's Changed
- docs(README): fix `cache_dependency_path` type by `@haines` in pnpm/action-setup#257
- fix: drop patchPnpmEnv so standalone+self-update works on Windows by `@zkochan` in pnpm/action-setup#258
- fix: update pnpm to 11.1.1 by `@mungodewar` in pnpm/action-setup#248

### New Contributors
- `@mungodewar` made their first contribution in pnpm/action-setup#248

Full Changelog: pnpm/action-setup@v6.0.7...v6.0.8

### v6.0.7

### What's Changed
- fix: honor devEngines.packageManager.onFail=error (#252) by `@zkochan` in pnpm/action-setup#254
- fix: restore inputs from state in post by `@haines` in pnpm/action-setup#255
- fix: self-update bootstrap to packageManager-pinned version (#233) by `@zkochan` in pnpm/action-setup#256

### New Contributors
- `@haines` made their first contribution in pnpm/action-setup#255

Full Changelog: pnpm/action-setup@v6.0.6...v6.0.7

... (truncated)

## Commits
- `ea17c68` feat: support pnpm v12 (#288)
- `0977fd9` docs: Update README to include devEngines.packageManager (#273)
- `48261ac` fix: update pnpm to v11.19.0 (#283)
- `75677f7` ci: use pnpm 11 for `pr-check` (#284)
- `769ae71` refactor: introduce restore keys for cache (#280)
- `6fed91f` docs(README): point users to the successor pnpm/setup action (#282)
- `0ebf471` fix: update pnpm to v11.7.0 (#267)
- `0e279bb` fix: update pnpm to 11.1.1 (#248)
- `3e83581` fix: drop patchPnpmEnv so standalone+self-update works on Windows (#258)
- `551b42e` docs(README): fix `cache_dependency_path` type (#257)
- Additional commits viewable in compare view
theinditector pushed a commit to IndicoDataSolutions/pnpm-action-setup that referenced this pull request Oct 28, 2026
* fix: update pnpm to v11.7.0 (pnpm#267)

* fix: update pnpm to v11.7.0

* fix: update bundle

* docs(README): point users to the successor pnpm/setup action (pnpm#282)

* docs(README): point users to the successor pnpm/setup action

The pnpm setup action has moved to `pnpm/setup`, which installs
pnpm v11+ as a self-contained native executable and can install a
JavaScript runtime (Node.js, Bun, or Deno) in the same step,
replacing `actions/setup-node`.

Add a notice at the top of the README, a migration section with a
before/after workflow example and an input/output mapping table,
and mention the successor in the Notes section. The rest of the
docs stay intact since `pnpm/action-setup` remains the way to
install pnpm v10 and older.

Signed-off-by: Kevin Cui <bh@bugs.cc>

* docs(README): address review feedback on migration section

Add an explicit version: 11 to the migration example and note when the
input can be omitted, since pnpm/setup requires pnpm v11+ and a repo
migrating from version: 10 may have no packageManager field or one that
pins v10.

Move the v2 upgrade warning below the page title so the two callouts
are no longer adjacent blockquotes (markdownlint MD028), keeping the
successor notice and the legacy warning as separate blocks.

Fix the comma splice and use "set up" as the verb in the Notes
section.

Signed-off-by: Kevin Cui <bh@bugs.cc>

---------

Signed-off-by: Kevin Cui <bh@bugs.cc>

* refactor: introduce restore keys for cache (pnpm#280)

* ci: use pnpm 11 for `pr-check` (pnpm#284)

Noticed while working on pnpm#283.

* fix: update pnpm to v11.19.0 (pnpm#283)

* fix: update pnpm to v11.19.0

Via `scripts/update-bootstrap.mjs 11.19.0`

Co-authored-by: Claude Sonnet 5 <jamie.tanna+claude-code@mend.io>

* fixup! fix: update pnpm to v11.19.0

As it needs to be rebuilt on Linux.

---------

Co-authored-by: Claude Sonnet 5 <jamie.tanna+claude-code@mend.io>

* docs: Update README to include devEngines.packageManager (pnpm#273)

Support added in pnpm#211 and pnpm#256

* feat: support pnpm v12 (pnpm#288)

* feat: support pnpm v12

Approve the pinned @pnpm/exe install script for npm 12, add pnpm 12 coverage across supported runner platforms, and clarify that action-setup remains supported alongside pnpm/setup.

* refactor: use pnpm 12 native bootstrap

Install the plain pnpm v12 package as the single native bootstrap, remove the legacy @pnpm/exe lockfile and runtime path, and retain the standalone input as a no-op for workflow compatibility.

* fix: keep bootstrap updates on pnpm 12

Handle npm's array-shaped view output and resolve only pnpm 12 distribution tags.

* fix: use native bootstrap only for pnpm 12

Route pnpm 12-only versions and ranges through the plain pnpm native package while preserving the existing Node and @pnpm/exe bootstrap paths for older releases.

* style: remove updater narrative comments

---------

Signed-off-by: Kevin Cui <bh@bugs.cc>
Co-authored-by: Zoltan Kochan <z@kochan.io>
Co-authored-by: Kevin Cui <github@bugs.cc>
Co-authored-by: Sukka <isukkaw@gmail.com>
Co-authored-by: Jamie Tanna <github@jamietanna.co.uk>
Co-authored-by: Jamie Tanna <jamie@jamietanna.co.uk>
Co-authored-by: Claude Sonnet 5 <jamie.tanna+claude-code@mend.io>
Co-authored-by: Eric Nemchik <eric@nemchik.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants