cli/cloud: fix pulumi insights account scan log pagination - #23256

Summary

scan log --all doesn't paginate to the end; and step mode comes back empty."

The Insights scan-logs endpoint and the Pulumi Deployments logs endpoint are served by the same server handler. The insights apitype had drifted away from that shape, which is the whole reason the bugs existed.

What this PR copies from apitype.DeploymentLogs / deployment_log.go:

• The response field is NextToken with json:"nextToken,omitempty" — matches what the server emits.
• Step mode returns a Lines array (not a raw Output string).
• The --all loop terminates only when the server emits an empty cursor.

Bug 1 — continuation mode (--all)

The server emits nextToken on the wire but apitype.InsightsScanLogs had the field tagged continuationToken. The struct field decoded to "" on every response, so the page loop terminated after the first page. Renamed ContinuationToken → NextToken with the matching JSON tag — same shape as apitype.DeploymentLogs, which is the same server handler.

Bug 2 — step mode (--job N --step M)

The server returns {lines: [{timestamp, line}, …]} in step mode too — same envelope as continuation mode, just scoped to one step, with nextOffset (an int line index) instead of nextToken. The previous step renderer wrote r.Output (a never-populated string field), so the command printed nothing. Dropped the dead Output field; both modes now share one line-oriented renderer.

--all in step mode follows the nextOffset chain to accumulate every page of lines.

What this PR deliberately does NOT copy from Deployments:

• The --count / --all semantics on insights account scan log are kept as-is (matching the rest of the Cloud-Ready Insights CLI surface — account list, account scan list).
• The --org + positional <account> scoping stays — Insights scopes by account, deployments scope by stack.

Follow-up worth considering (not in this PR)

apitype.DeploymentLogs and apitype.InsightsScanLogs are now literally the same shape (Lines []…, NextToken string, plus step-mode NextOffset int64). They could be unified into a single apitype.WorkflowLogs struct shared between the two endpoints. Similarly, the --all loops in deployment_log.go and insights_account_scan_log.go are nearly identical and could share a helper. Both would be refactors that should touch deployments and insights together, not be smuggled into a bug fix.

Sample output (before / after)

--all continuation mode

# Before: stops after one page (~100 lines)
$ pulumi insights account scan log "Michael-Test-AWS/us-east-2" 7bb80f16-… --org pulumi --all | wc -l
100

# After: follows the cursor to the end
$ pulumi insights account scan log "Michael-Test-AWS/us-east-2" 7bb80f16-… --org pulumi --all | wc -l
8099

--job N --step M --all step mode

# Before: empty output
$ pulumi insights account scan log "Michael-Test-AWS/us-east-2" 7bb80f16-… --org pulumi --job 0 --step 0 --all
(empty)

# After: prints the step's log lines and follows nextOffset
$ pulumi insights account scan log "Michael-Test-AWS/us-east-2" 7bb80f16-… --org pulumi --job 0 --step 0 --all
2026-01-21T15:59:15Z Preparing environment
2026-01-21T15:59:17Z Using runner default image with Pulumi version 3.216.0 …
2026-01-21T15:59:17Z Starting container
2026-01-21T15:59:26Z Container created …
2026-01-21T15:59:26Z Container started …
…

For a step whose log spans multiple nextOffset pages (step 3 in the example above), --all now fetches the full content:

$ pulumi insights account scan log "Michael-Test-AWS/us-east-2" 7bb80f16-… --org pulumi --job 0 --step 3 --all | wc -l
8081

Test plan

• Updated unit tests for both modes to use the real server response shape (lines array in step mode, nextToken in continuation mode).
• Updated client_insights_test.go to round-trip the same shape.
• mise exec -- make format
• mise exec -- make lint (0 issues across 7 packages)
• Live smoke against the pulumi org: continuation --all returns 8099 lines (was ~100), step-mode --job 0 --step 0 --all returns the step's log content (was empty), step 3 --all fetches 8081 lines across multiple nextOffset pages.

🤖 Generated with Claude Code