Visitar URL original
Support import pending creates parameter by miguelslemos · Pull Request #23833 · pulumi/pulumi · GitHub
Skip to content

Support import pending creates parameter - #23833

Merged
tgummerer merged 2 commits into
pulumi:masterfrom
miguelslemos:implement-import-pending-creates
Jul 14, 2026
Merged

Support import pending creates parameter#23833
tgummerer merged 2 commits into
pulumi:masterfrom
miguelslemos:implement-import-pending-creates

Conversation

@miguelslemos

@miguelslemos miguelslemos commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Added appropriate unit tests - For all changes
  • Added a test in pkg/engine/lifecycletest - For all engine/protocol changes
  • Added a conformance test in pkg/testing/pulumi-test-language - For language protocol changes
  • Added a golden test in pkg/backend/display - For changes to the output renderers

Validation

  • make lint — clean
  • make test_fast — all pass
  • make tidy_fix — clean
  • make format — clean
  • Relevant SDK tests pass (if SDK changes)
  • make check_proto — clean (if proto changes)

Changelog

  • Changelog entry added. If you do not believe this PR requires a changelog, ask a maintainer to apply
    the impact/no-changelog-required label.

Risk

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@miguelslemos
miguelslemos marked this pull request as ready for review July 8, 2026 18:05
@miguelslemos
miguelslemos requested a review from a team as a code owner July 8, 2026 18:05
@iwahbe

iwahbe commented Jul 9, 2026 •
edited by pulumi-bot
Loading

Copy link
Copy Markdown
Member

/run-acceptance-tests
Please view the results of the acceptance tests Here

Frassle
Frassle approved these changes Jul 9, 2026
View reviewed changes

@Frassle Frassle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks

tgummerer
tgummerer reviewed Jul 9, 2026
View reviewed changes
Comment thread changelog/pending/20260708--auto-go--support-import-pending-creates-for-refresh.yaml Outdated
@@ -0,0 +1,4 @@
changes:

@tgummerer tgummerer Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the old changelog format. Could you please run make changelog from an up to date master branch and recreate this?

@miguelslemos miguelslemos Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you confirm that is correctly now, please?

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@tgummerer
tgummerer enabled auto-merge July 14, 2026 06:24
@tgummerer
tgummerer added this pull request to the merge queue Jul 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 14, 2026
@tgummerer
tgummerer added this pull request to the merge queue Jul 14, 2026
Merged via the queue into pulumi:master with commit deb8acf Jul 14, 2026
6 checks passed
@pulumi-bot

pulumi-bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v3.253.0.

@miguelslemos
miguelslemos deleted the implement-import-pending-creates branch July 14, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgummerer tgummerer tgummerer left review comments
@Frassle Frassle Frassle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miguelslemos @iwahbe @pulumi-bot @tgummerer @Frassle