Visitar URL original
Skip the unconsumed release-binary rebuild on pull requests by vova-ivanov · Pull Request #24595 · pulumi/pulumi · GitHub
Skip to content

Skip the unconsumed release-binary rebuild on pull requests - #24595

Merged
vova-ivanov merged 1 commit into
masterfrom
vova/skip-release-rebuild-on-prs
Sep 9, 2026
Merged

vova-ivanov merged 1 commit into
masterfrom
vova/skip-release-rebuild-on-prs

Conversation

@vova-ivanov

Copy link
Copy Markdown
Contributor

Every PR run rebuilds all six CLI binaries a second time, without coverage instrumentation. Those binaries exist only for release packaging; the merge queue consumes them, while test jobs download the separately named test binaries and dev releases build their own. This change skips the rebuild on PRs, while leaving leaves the merge queue and releases untouched.

Changes

  • ci.yml gets a new rebuild-release-binaries input. It is required and has no default, so every caller states explicitly whether its run packages release artifacts.
  • The merge queue passes true: its release-prepare step consumes the rebuilt binaries, exactly as before.
  • PR runs, the daily cron, and dispatch-triggered fork acceptance runs pass false. None of them package releases (the cron and dispatch runs also disable coverage, so the rebuild never ran there anyway — now that is explicit instead of incidental).

@vova-ivanov
vova-ivanov requested a review from a team as a code owner September 8, 2026 22:47

@Frassle Frassle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, saves some more CI time :)

@vova-ivanov
vova-ivanov added this pull request to the merge queue Sep 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 9, 2026
@vova-ivanov
vova-ivanov added this pull request to the merge queue Sep 9, 2026
Merged via the queue into master with commit 4e97075 Sep 9, 2026
235 of 237 checks passed
@vova-ivanov
vova-ivanov deleted the vova/skip-release-rebuild-on-prs branch September 9, 2026 18:18
pull Bot pushed a commit to makesoftwaresafe/pulumi that referenced this pull request Sep 14, 2026
…ulumi#24649)

Reverts pulumi#24595

Both `pulumi/actions` `pr#<number>` version & `curl -sSL
https://get.pulumi.com | sh -s -- --version pr#<number>` install the
binaries pulumi#24595 removed.

If we want to stop building & publishing these, we need to come up with
an alternative first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants