refactor: type the syntax print context's get as string, add lookup - #23304

🦋 Changeset detected

Latest commit: 662f6a9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

_{Reports for 662f6a9, computed by this pull request's own code. Each section updates when its workflow finishes.}

Preview package

This PR is packaged and the instant preview of its latest commit is available.

Install it locally:

• npm

npm i -D webpack@https://pkg.pr.new/webpack@23304

• yarn

yarn add -D webpack@https://pkg.pr.new/webpack@23304

• pnpm

pnpm add -D webpack@https://pkg.pr.new/webpack@23304

_{From Preview package run #12830.}

Generated code size

Comparing base (5f22430) to head (662f6a9). Merging this pull request will not change the code webpack generates.

Read Changed, test untouched first: the test is byte-identical on both sides, so webpack generated the difference. Changed, test edited moved partly because the test did — Test edit is how many bytes the test gained, and a bundle that grew by less is not a regression. New and Deleted are whole files, not deltas — a new asset was created, not grown, so it reads gray (⚪ added) — and adding tests cannot bury a real change. Gzip decides, because that is what users download; raw is the tiebreak, and brotli and zstd are per asset below.

Sample apps

No sample app changed size.

No asset changed size.

No runtime gained or lost a runtime module.

Built test/configCases with the defaults a user gets, and the apps in test/sizeCoreReports (apps/): 2520 test(s), 10392 asset(s), 109 emitted nothing.

_{From Generated code size run #7465.}

Types Coverage

Typed lines: 99.70% (184742 of 185297)

any counts EXPECTED_ANY, a written any and the any TypeScript infers where no type is written, such as const map = new Map() or const list = []. unknown counts a written unknown; ThrownValue, the unknown a throw or a rejected promise hands on, is left out. object counts EXPECTED_OBJECT and Object, Function counts EXPECTED_FUNCTION. Untyped counts the identifiers whose type is or holds any, wherever it comes from; the any TypeScript's built-in lib and Node.js's @​types/node write in their own signatures, such as the replacer of String#replace or a stream's chunk, is left out, and so is the open fallback beside declared fields, such as KnownBuildInfo & Record<string, any>, though reading a key no field declares is counted.

Changed by this pull request

_{From Types Coverage run #3684.}

Module loading

How many files a fresh Node.js process loads (require or import) to do each thing below; a change from the pull request's base is marked 🔴 when it grew and 🟢 when it shrank. Every file is startup time, so fewer is better. webpack files are this package's own (lib/, hot/); node_modules files are its dependencies'.

_{From Module loading run #928.}

No actionable comments were generated in the recent review.

Change: Refactor

Merge Risk: Minimal · up to 662f6

This refactor separates "no printed text" from "empty text" in the syntax print context, and the affected printer call sites keep their previous behavior. The changeset filename now follows the required convention. No concrete merge-blocking risk remains in the reviewed changes.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title uses the conventional-commit form with type "refactor", which is an allowed type. It names the main change: the print context's get is typed as string, and a new lookup method is added. The …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title uses the conventional-commit form with type "refactor", which is an allowed type. It names the main change: the print context's get is typed as string, and a new lookup method is added. The changeset supports this. The title is clear and matches the changes in SourceProcessor.js and the call sites that use lookup. The branch prefix was not provided, so the match between type and branch prefix could not be checked.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Recent review info

Run configuration

• Source mode: Auto
• Repository: webpack/webpack
• Branch: refactor/zero-escape-hatches
• File: .coderabbit.yaml
• Commit: 662f6a9
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 157ff604-90b7-46e2-9ca0-af82c627d45d

Commits

Reviewing files that changed from the base of the PR and between 9260626 and 662f6a9.

Files ignored due to path filters: 1

• types.d.ts is excluded by !types.d.ts

Files selected for processing: 1

• .changeset/268-print-context-lookup.md

Files with no reviewable changes: 1

• .changeset/268-print-context-lookup.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (5f22430) to head (662f6a9).

@@           Coverage Diff           @@
##             main   #23304   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         807      807           
  Lines      145166   145168    +2     
  Branches    50384    50385    +1     
=======================================
+ Hits       140807   140810    +3     
+ Misses       4359     4358    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

• ✅ Unknown (9260626)
• ✅ login: alexander-akait / name: alexander-akait (662f6a9, 9260626)
• ❌ - login: @claude / name: Claude. The commit (8db0ac9) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via:

Co-authored-by: name <email>

Supported Co-authored-by: formats include:

1. Anything <id+login@users.noreply.github.com> - it will locate your GitHub user by id part.
2. Anything <login@users.noreply.github.com> - it will locate your GitHub user by login part.
3. Anything <public-email> - it will locate your GitHub user by public-email part. Note that this email must be made public on Github.
4. Anything <other-email> - it will locate your GitHub user by other-email part but only if that email was used before for any other CLA as a main commit author.
5. login <any-valid-email> - it will locate your GitHub user by login part, note that login part must be at least 3 characters long.

Alternatively, if the co-author should not be included, remove the Co-authored-by: line from the commit message.

Please update your commit message(s) by doing git commit --amend and then git push [--force] and then request re-running CLA check via commenting on this pull request:

/easycla

Merging this PR will degrade performance by 20.21%

❌ 1 regressed benchmark
✅ 350 untouched benchmarks

Performance Changes

_{Comparing refactor/zero-escape-hatches (662f6a9) with main (5f22430)}