Visitar URL original
feat: introduce Bigtable Admin V2 clients for Selective GAPIC by jinseopkim0 · Pull Request #2889 · googleapis/java-bigtable · GitHub
Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

feat: introduce Bigtable Admin V2 clients for Selective GAPIC - #2889

Closed
jinseopkim0 wants to merge 34 commits into
mainfrom
refactor-consistency-request-2
Closed

feat: introduce Bigtable Admin V2 clients for Selective GAPIC#2889
jinseopkim0 wants to merge 34 commits into
mainfrom
refactor-consistency-request-2

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

This commit adds BigtableTableAdminClientV2 and BigtableInstanceAdminClientV2, which extend the autogenerated base clients. These classes serve as the new, independent entry points for the Selective GAPIC hierarchy.

For BigtableTableAdminClientV2, the manual wrappers for Critical User Journeys (CUJs) like awaitOptimizeRestoredTable and waitForConsistency have been relocated from the legacy client. It utilizes the new context-free ConsistencyRequest factories introduced in the previous refactoring step.

For BigtableInstanceAdminClientV2, the class acts as a standardized entry point, as no manual overrides were required from the legacy client.

b/502616786

jinseopkim0 and others added 2 commits April 15, 2026 14:35
@jinseopkim0
refactor: decouple ConsistencyRequest from TableAdminRequestContext
b68d628 
This commit updates the internal plumbing for `ConsistencyRequest` and
`AwaitConsistencyCallable` to support fully qualified table names without
breaking the existing public API for the legacy `BigtableTableAdminClient`.

b/502616786
@cloud-java-bot
chore: generate libraries at Wed Apr 15 18:37:03 UTC 2026
6e39723
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 15, 2026
@jinseopkim0
jinseopkim0 force-pushed the refactor-consistency-request-2 branch 2 times, most recently from 979d668 to eabb07a Compare April 15, 2026 20:03
@jinseopkim0
feat: introduce Bigtable Admin V2 clients for Selective GAPIC
00db638 
This commit adds `BigtableTableAdminClientV2` and `BigtableInstanceAdminClientV2`,
which extend the autogenerated base clients. These classes serve as the new,
independent entry points for the Selective GAPIC hierarchy.

For `BigtableTableAdminClientV2`, the manual wrappers for Critical User
Journeys (CUJs) like `awaitOptimizeRestoredTable` and `waitForConsistency`
have been relocated from the legacy client. It utilizes the new context-free
ConsistencyRequest factories introduced in the previous refactoring step.

For `BigtableInstanceAdminClientV2`, the class acts as a standardized entry
point, as no manual overrides were required from the legacy client.

b/502616786
@jinseopkim0
jinseopkim0 force-pushed the refactor-consistency-request-2 branch from 849de6d to 00db638 Compare April 15, 2026 20:12
@jinseopkim0
jinseopkim0 marked this pull request as ready for review April 16, 2026 00:35
@jinseopkim0
jinseopkim0 requested review from a team as code owners April 16, 2026 00:35
@jinseopkim0
jinseopkim0 requested a review from lqiu96 April 16, 2026 00:36
igorbernstein2
igorbernstein2 suggested changes Apr 16, 2026
View reviewed changes
Comment thread ...ud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientV2.java Resolved
Comment thread ...ud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientV2.java Resolved
@jinseopkim0 jinseopkim0 mentioned this pull request Apr 21, 2026
Merged
Base automatically changed from refactor-consistency-request to main April 22, 2026 19:23
@jinseopkim0 jinseopkim0 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2026
@jinseopkim0 jinseopkim0 mentioned this pull request Apr 24, 2026
Closed
lqiu96
lqiu96 reviewed Apr 24, 2026
View reviewed changes
Comment thread ...bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClientV2.java Resolved
lqiu96
lqiu96 approved these changes Apr 24, 2026
View reviewed changes

@lqiu96 lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes overall LGTM.

igorbernstein2
igorbernstein2 suggested changes Apr 27, 2026
View reviewed changes
Comment thread ...ud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientV2.java Resolved
Comment thread ...ud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientV2.java Resolved
Comment thread ...ud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientV2.java Resolved
@generated-files-bot

generated-files-bot Bot commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java

igorbernstein2
igorbernstein2 suggested changes Apr 28, 2026
View reviewed changes
Comment thread ...bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitConsistencyCallable.java Resolved
Comment thread ...bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitConsistencyCallable.java Resolved
Comment thread ...bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitConsistencyCallable.java Resolved
Comment thread ...ud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientV2.java Resolved
@jinseopkim0 jinseopkim0 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2026
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2026
@meltsufin meltsufin closed this May 8, 2026
@jinseopkim0 jinseopkim0 mentioned this pull request May 12, 2026
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2
1 more reviewer
@lqiu96 lqiu96 lqiu96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jinseopkim0 @lqiu96 @igorbernstein2 @meltsufin @yoshi-kokoro @cloud-java-bot