Visitar URL original

docs: Add preconditions to some samples by JesseLovelace · Pull Request #1600 · googleapis/java-storage · GitHub

This repository was archived by the owner on Sep 25, 2026. It is now read-only.

Repository navigation

docs: Add preconditions to some samples - #1600

Merged

JesseLovelace merged 7 commits into

mainfrom

Sep 23, 2022

Merged

docs: Add preconditions to some samples#1600
JesseLovelace merged 7 commits into
mainfrom
jesseprecon

JesseLovelace commented Aug 31, 2022

Contributor

Adds preconditions to some Java samples. This is half the samples that need to be added, @sydney-munro is going to do the other half


          docs: Add preconditions to some samples

1c93676

JesseLovelace requested a review from frankyn

August 31, 2022 01:13

product-auto-label Bot added size: m api: storage samples labels

blunderbuss-gcf Bot assigned Shabirmean


          🦉 Updates from OwlBot post-processor

4eded73

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-owl-bot Bot requested review from a team

August 31, 2022 01:16

Shabirmean reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/ComposeObject.java Resolved

Shabirmean reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/CopyObject.java Resolved

Shabirmean reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/CopyObject.java Resolved

Shabirmean reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/CopyOldVersionOfObject.java Resolved

Shabirmean reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/MoveObject.java Resolved

Shabirmean reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/UploadEncryptedObject.java Resolved

Shabirmean reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/UploadKmsEncryptedObject.java Resolved

Shabirmean reviewed

View reviewed changes

Shabirmean left a comment

LGTM Overall.

Some minor formatting related comments. Also PTAL at the failing tests

JesseLovelace added 2 commits

August 31, 2022 14:58


          remove star import


          Merge branch 'jesseprecon' of github.com:googleapis/java-storage into…

91c48f0

… jesseprecon

BenWhitehead reviewed

View reviewed changes

samples/snippets/src/main/java/com/example/storage/object/ChangeObjectCsekToKms.java Outdated

+                  // conditions and data corruptions. The request to upload returns a 412 error if
+                  // the object's generation number does not match your precondition.
+                  Storage.BlobSourceOption precondition =
+                      Storage.BlobSourceOption.generationMatch(storage.get(blobId).getGeneration());

BenWhitehead Sep 6, 2022

Collaborator

This could 404 and return null if there isn't an object for blobId. Possibly move it to it's own line to ease debugging?

samples/snippets/src/main/java/com/example/storage/object/ChangeObjectStorageClass.java Outdated

+                  // conditions and data corruptions. The request to upload returns a 412 error if
+                  // the object's generation number does not match your precondition.
+                  Storage.BlobSourceOption precondition =
+                      Storage.BlobSourceOption.generationMatch(storage.get(blobId).getGeneration());

BenWhitehead Sep 6, 2022

Collaborator

ditto

samples/snippets/src/main/java/com/example/storage/object/DeleteObject.java Outdated

+                  // the object's generation number does not match your precondition.
+                  Storage.BlobSourceOption precondition =
+                      Storage.BlobSourceOption.generationMatch(
+                          storage.get(bucketName, objectName).getGeneration());

BenWhitehead Sep 6, 2022

Collaborator

ditto

samples/snippets/src/main/java/com/example/storage/object/RotateObjectEncryptionKey.java Outdated

+                  // conditions and data corruptions. The request to upload returns a 412 error if
+                  // the object's generation number does not match your precondition.
+                  Storage.BlobSourceOption precondition =
+                      Storage.BlobSourceOption.generationMatch(storage.get(blobId).getGeneration());

BenWhitehead Sep 6, 2022

Collaborator

ditto

JesseLovelace and others added 2 commits

September 7, 2022 14:49


          add null checks

cc483c0


          🦉 Updates from OwlBot post-processor

438cc45

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

BenWhitehead approved these changes

View reviewed changes

BenWhitehead left a comment

Collaborator

Thanks for adding the null checks!

Shabirmean approved these changes

View reviewed changes

JesseLovelace added the kokoro:force-run label

yoshi-kokoro removed the kokoro:force-run label


          Merge branch 'main' into jesseprecon

e7e4b71

JesseLovelace merged commit 4b3be44 into main

JesseLovelace deleted the jesseprecon branch

September 23, 2022 18:15

release-please Bot mentioned this pull request

chore(main): release 2.13.0 #1636

Merged

gcf-merge-on-green Bot pushed a commit that referenced this pull request


          chore(main): release 2.13.0 (#1636)

c54eb19

🤖 I have created a release *beep* *boop*
---


## [2.13.0](https://togithub.com/googleapis/java-storage/compare/v2.12.0...v2.13.0) (2022-10-03)


### Features

* Regenerate gapic storage v2 client as of googleapis/googleapis@844d0f7 ([#1673](https://togithub.com/googleapis/java-storage/issues/1673)) ([bd818b3](https://togithub.com/googleapis/java-storage/commit/bd818b311186c37ceb527630ed56755d89e2b71b))


### Documentation

* Add preconditions to some samples ([#1600](https://togithub.com/googleapis/java-storage/issues/1600)) ([4b3be44](https://togithub.com/googleapis/java-storage/commit/4b3be44bd4c53613f08bbd01d3b4a9ded419565d))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1685](https://togithub.com/googleapis/java-storage/issues/1685)) ([3d8f550](https://togithub.com/googleapis/java-storage/commit/3d8f550e4d646a7d4bda6f9e74bc5996d573d5b4))
* Update dependency gcp-releasetool to v1.8.9 ([#1684](https://togithub.com/googleapis/java-storage/issues/1684)) ([54a5159](https://togithub.com/googleapis/java-storage/commit/54a5159707efd6a2d4abd0273ab7c279f507005b))
* Update dependency importlib-metadata to v4.13.0 ([#1682](https://togithub.com/googleapis/java-storage/issues/1682)) ([2487aff](https://togithub.com/googleapis/java-storage/commit/2487affad5a1adf1c39589d8f8a976c7f245b0c9))
* Update dependency importlib-metadata to v5 ([#1683](https://togithub.com/googleapis/java-storage/issues/1683)) ([020fe8c](https://togithub.com/googleapis/java-storage/commit/020fe8ce7991e8c72135a2912f615ed50cc68fd4))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.14 ([#1643](https://togithub.com/googleapis/java-storage/issues/1643)) ([ab3a198](https://togithub.com/googleapis/java-storage/commit/ab3a198115ae637710982f838231d2d36c029486))
* Update dependency org.junit.vintage:junit-vintage-engine to v5.9.1 ([#1635](https://togithub.com/googleapis/java-storage/issues/1635)) ([ba85ab6](https://togithub.com/googleapis/java-storage/commit/ba85ab6ce9304b4c426538d2bacc99ef73ed2b0e))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage samples size: m