Visitar URL original
Quickstart guides for Native Image Build Tools Maven/Gradle plugins. by olyagpl · Pull Request #381 · graalvm/native-build-tools · GitHub
Skip to content

Quickstart guides for Native Image Build Tools Maven/Gradle plugins. - #381

Merged
olyagpl merged 11 commits into
masterfrom
ogupalo/quickstart-guides
Jan 9, 2023
Merged

Quickstart guides for Native Image Build Tools Maven/Gradle plugins.#381
olyagpl merged 11 commits into
masterfrom
ogupalo/quickstart-guides

Conversation

@olyagpl

@olyagpl olyagpl commented Dec 21, 2022

Copy link
Copy Markdown
Member

Add quickstart guides for beginners, using a “clean” Java project. The guide shows how to create a demo app, enable Maven/Gradle plugin, provide the required configuration, build a native executable, and add and run jUnit tests.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 21, 2022
melix added 2 commits December 23, 2022 18:23
@melix
Fix Gradle quickstart guide
40d5e6c 
- fix broken links
- fix some unclear instructions and typos
- make Gradle snippets multilanguage
- use a token for the plugin version to keep docs in sync
@melix
Fix Maven quickstart guide
9d953c4 
- fix broken links
- clarify some sections
- add missing unit test
@melix

melix commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

@olyagpl I have made some fixes to the docs, checked the instructions step by step and now LGTM!

@olyagpl

olyagpl commented Jan 2, 2023

Copy link
Copy Markdown
Member Author

@melix, thanks for reviewing and adding Kotlin/Groovy versions!

fniephaus
fniephaus requested changes Jan 5, 2023
View reviewed changes
Comment thread docs/src/docs/asciidoc/graalvm-setup.adoc Outdated
Comment thread docs/src/docs/asciidoc/graalvm-setup.adoc Outdated
Comment thread docs/src/docs/asciidoc/graalvm-setup.adoc Outdated
Comment thread docs/src/docs/asciidoc/gradle-plugin.adoc Outdated
Comment thread docs/src/docs/asciidoc/maven-plugin.adoc Outdated
Comment thread docs/src/docs/asciidoc/gradle-plugin-quickstart.adoc Outdated
Comment thread docs/src/docs/asciidoc/gradle-plugin-quickstart.adoc
Comment thread docs/src/docs/asciidoc/gradle-plugin-quickstart.adoc Outdated
Comment thread docs/src/docs/asciidoc/maven-plugin-quickstart.adoc Outdated
Comment thread docs/src/docs/asciidoc/maven-plugin-quickstart.adoc Outdated
@olyagpl
olyagpl force-pushed the ogupalo/quickstart-guides branch from 84f6219 to 8262092 Compare January 5, 2023 11:02
olyagpl and others added 2 commits January 5, 2023 13:03
@olyagpl @fniephaus
Follow Fabio Niephaus comments
8262092 
Co-authored-by: Fabio Niephaus <code@fniephaus.com>
@olyagpl @fniephaus
Update docs/src/docs/asciidoc/gradle-plugin-quickstart.adoc
dd5eebc 
Co-authored-by: Fabio Niephaus <code@fniephaus.com>
@olyagpl
olyagpl requested a review from fniephaus January 5, 2023 12:32
fniephaus
fniephaus approved these changes Jan 5, 2023
View reviewed changes

@fniephaus fniephaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@olyagpl

olyagpl commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@shaunsmith suggestion is also to talk about the GraalVM download scripts in Graalvm-setup.adoc as in the quickstart guides.

The download script will provide the env vars, e.g.,
Run the following to set your $GRAALVM_HOME, $PATH, and/or $JAVA_HOME:
$ export GRAALVM_HOME="/Users/shaun/tmp/graalvm-ee-java17-22.3.0/Contents/Home"
$ export PATH="/Users/shaun/tmp/graalvm-ee-java17-22.3.0/Contents/Home/bin:$PATH"
$ export JAVA_HOME="/Users/shaun/tmp/graalvm-ee-java17-22.3.0/Contents/Home"

@melix, let's incorporate https://github.com/graalvm/graalvm-jdk-downloader in a followup PR?

@olyagpl
olyagpl merged commit 93318bf into master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melix melix melix approved these changes
@fniephaus fniephaus fniephaus approved these changes
@shaunsmith shaunsmith Awaiting requested review from shaunsmith

Assignees

@melix melix

@olyagpl olyagpl

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olyagpl @melix @fniephaus