Visitar URL original
BigQuery: Move maybe_fail_import() to top level test utils by plamut · Pull Request #8840 · googleapis/google-cloud-python · GitHub
Skip to content

BigQuery: Move maybe_fail_import() to top level test utils - #8840

Merged
plamut merged 2 commits into
googleapis:masterfrom
plamut:move-test-util
Jul 31, 2019
Merged

BigQuery: Move maybe_fail_import() to top level test utils#8840
plamut merged 2 commits into
googleapis:masterfrom
plamut:move-test-util

Conversation

@plamut

@plamut plamut commented Jul 31, 2019

Copy link
Copy Markdown
Contributor

Following a recent discussion, this PR moves a test utility from BigQuery to the top-level test utils, since it is considered useful outside of BigQuery, too.

How to test

Primarily verify that the promoted utility function is general enough for the promotion.

@plamut plamut added testing api: bigquery Issues related to the BigQuery API. labels Jul 31, 2019
@plamut
plamut requested review from a team and busunkim96 July 31, 2019 10:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2019
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2019
tseaver
tseaver reviewed Jul 31, 2019
View reviewed changes
Comment thread bigquery/noxfile.py Resolved
@plamut
plamut requested a review from tseaver July 31, 2019 18:46
@plamut
plamut merged commit e688b0e into googleapis:master Jul 31, 2019
@plamut
plamut deleted the move-test-util branch July 31, 2019 20:15
@plamut plamut changed the title Move maybe_fail_import() to top level test utils BigQuery: Move maybe_fail_import() to top level test utils Aug 22, 2019
@plamut plamut mentioned this pull request Oct 22, 2019
Merged
@tseaver

tseaver commented Jul 7, 2021

Copy link
Copy Markdown
Contributor

FWIW, after two years, there are exactly zero uses of maybe_fail_import outside of the python-bigquery repo.

@plamut

plamut commented Jul 8, 2021

Copy link
Copy Markdown
Contributor Author

Sounds like we need to run a large-scale AdWords campaign to promote its usage.

@tseaver Are you suggesting that it might be better to move this back to the python-bigquery repo?

@tseaver

tseaver commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

@plamut

Are you suggesting that it might be better to move this back to the python-bigquery repo?

I'm not sure. I came across it while working on googleapis/python-test-utils#43: the function has no test coverage, which meant that I had to install a development version into a virtualenv along with python-bigquery so that I could test that I didn't break anything.

@plamut

plamut commented Jul 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@tseaver I see. Sounds like a one-off (ish) annoyance, thus might not be worth it. We could cover it with tests, however, I'll create a ticket to track it.

Edit: Created.

@plamut plamut mentioned this pull request Jul 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96
1 more reviewer
@tseaver tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plamut @tseaver @googlebot @yoshi-kokoro