Visitar URL original
Fix marshaling new-style union literals by Gabriella439 · Pull Request #918 · dhall-lang/dhall-haskell · GitHub
Skip to content

Fix marshaling new-style union literals - #918

Merged
Gabriella439 merged 1 commit into
masterfrom
gabriel/marshal_union_literals
Apr 30, 2019
Merged

Gabriella439 merged 1 commit into
masterfrom
gabriel/marshal_union_literals

Conversation

@Gabriella439

Copy link
Copy Markdown
Collaborator

Fixes #915

@quasicomputational

Copy link
Copy Markdown
Collaborator

LGTM!

@Gabriella439
Gabriella439 merged commit 07c9c62 into master Apr 30, 2019
@Gabriella439
Gabriella439 deleted the gabriel/marshal_union_literals branch April 30, 2019 15:18
quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this pull request May 1, 2019
I discovered it wasn't working right in dhall-lang#926. The underlying bug is
very similar to dhall-lang#915, and in fact this builds on the fix for that in dhall-lang#918.

It looks like the single-constructor case is a different underlying
bug that I don't understand just yet, so let's tackle that separately.
quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this pull request May 1, 2019
The underlying bug is very similar to dhall-lang#915, and in fact this builds on
the fix for that in dhall-lang#918.

Closes dhall-lang#926.
quasicomputational added a commit to quasicomputational/dhall-haskell that referenced this pull request May 2, 2019
The underlying bug is very similar to dhall-lang#915, and in fact this builds on
the fix for that in dhall-lang#918.

Closes dhall-lang#926.
Gabriella439 pushed a commit that referenced this pull request May 2, 2019
The underlying bug is very similar to #915, and in fact this builds on
the fix for that in #918.

Closes #926.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.22: union construction seems not to be normalised

2 participants