Visitar URL original
MNT Narwhals in `utils._input_validations` by EdAbati · Pull Request #1533 · fairlearn/fairlearn · GitHub
Skip to content
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
68d71db
added test for test_merge_columns
EdAbati Mar 7, 2025
c560b7c
small doc fix
EdAbati Mar 7, 2025
b00855a
update requirements
EdAbati Mar 7, 2025
54ab71c
first draft
EdAbati Mar 7, 2025
8e1b77a
update tests
EdAbati Mar 7, 2025
0c0a8d4
added confests as in #1525
EdAbati Mar 7, 2025
10f8f9b
draft
EdAbati Mar 12, 2025
999f578
removed pandas from _merge_columns
EdAbati Mar 12, 2025
8ccb6ff
Merge remote-tracking branch 'origin/refactor-_merge_columns' into na…
EdAbati Mar 12, 2025
c006eef
Merge remote-tracking branch 'upstream/main' into narwhals-in-utils
EdAbati Mar 13, 2025
7424428
update narwhals compat
EdAbati Mar 13, 2025
7eb7f76
restart
EdAbati Mar 13, 2025
12b6408
Merge remote-tracking branch 'upstream/main' into narwhals-in-utils
EdAbati Mar 20, 2025
dfe473b
fix error message
EdAbati Mar 20, 2025
b8adf04
small refactor
EdAbati Mar 20, 2025
b24550e
update standardize features
EdAbati Mar 23, 2025
5598370
update tests
EdAbati Mar 25, 2025
b4936f1
readd pyarrow
EdAbati Mar 25, 2025
7c06811
Merge remote-tracking branch 'upstream/main' into narwhals-in-utils
EdAbati Apr 23, 2025
8291e2f
human readable doc string
EdAbati Apr 24, 2025
7ae2ce6
simplify all_to_native
EdAbati Apr 24, 2025
cfaa68e
implement feedback get_native_namespace_or_default
EdAbati Apr 24, 2025
472998f
add pyarrow in default backend priority
EdAbati Apr 24, 2025
3b124b9
update docstring
EdAbati Apr 24, 2025
8285a5d
update changelog
EdAbati Apr 24, 2025
9c25218
Merge remote-tracking branch 'upstream/main' into narwhals-in-utils
EdAbati May 1, 2025
e5f0d02
allow setting a default implementation in the objects that don't supp…
EdAbati May 1, 2025
85bc63c
Merge branch 'main' into narwhals-in-utils
EdAbati May 4, 2025
18ce901
add narwhals compat tests
EdAbati May 4, 2025
470cc1a
fix
EdAbati May 4, 2025
bc63d5c
test get_default_dataframe_backend
EdAbati May 4, 2025
f364aa8
merge upstream
EdAbati May 24, 2025
87513c9
Merge branch 'main' into narwhals-in-utils
romanlutz Jun 29, 2026
af7f1de
TST Handle missing polars in narwhals compat tests
romanlutz Jun 30, 2026
933cf57
Merge branch 'main' into narwhals-in-utils
romanlutz Aug 19, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TST Handle missing polars in narwhals compat tests
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
romanlutz and Copilot committed Jun 30, 2026
commit af7f1de019f2809ca7df1eb420c14093719b730e
89 changes: 62 additions & 27 deletions test/unit/utils/test_narwhals_compat.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Copyright (c) Fairlearn contributors.
# Licensed under the MIT License.

from importlib.util import find_spec
from unittest.mock import patch

import narwhals.stable.v1 as nw
import numpy as np
import pandas as pd
import polars as pl
import pytest
from narwhals.stable.v1 import Implementation

Expand All @@ -16,6 +16,13 @@
get_native_namespace_or_default,
)

POLARS_AVAILABLE = find_spec("polars") is not None

if POLARS_AVAILABLE:
import polars as pl

DEFAULT_BACKEND = Implementation.POLARS if POLARS_AVAILABLE else Implementation.PANDAS


@pytest.mark.parametrize(
"polars_available, pandas_available, pyarrow_available, expected_backend",
Expand All @@ -31,13 +38,17 @@
def test_get_default_dataframe_backend(
polars_available, pandas_available, pyarrow_available, expected_backend
):
with patch(
"fairlearn.utils._narwhals_compat.get_polars", return_value=polars_available
) as mock_get_polars, patch(
"fairlearn.utils._narwhals_compat.get_pandas", return_value=pandas_available
) as mock_get_pandas, patch(
"fairlearn.utils._narwhals_compat.get_pyarrow", return_value=pyarrow_available
) as mock_get_pyarrow:
with (
patch(
"fairlearn.utils._narwhals_compat.get_polars", return_value=polars_available
) as mock_get_polars,
patch(
"fairlearn.utils._narwhals_compat.get_pandas", return_value=pandas_available
) as mock_get_pandas,
patch(
"fairlearn.utils._narwhals_compat.get_pyarrow", return_value=pyarrow_available
) as mock_get_pyarrow,
):
backend = get_default_dataframe_backend()

assert backend == expected_backend
Expand All @@ -55,9 +66,11 @@ def test_get_default_dataframe_backend(


def test_get_default_dataframe_backend_error():
with patch("fairlearn.utils._narwhals_compat.get_polars", return_value=False), patch(
"fairlearn.utils._narwhals_compat.get_pandas", return_value=False
), patch("fairlearn.utils._narwhals_compat.get_pyarrow", return_value=False):
with (
patch("fairlearn.utils._narwhals_compat.get_polars", return_value=False),
patch("fairlearn.utils._narwhals_compat.get_pandas", return_value=False),
patch("fairlearn.utils._narwhals_compat.get_pyarrow", return_value=False),
):
with pytest.raises(ImportError) as excinfo:
get_default_dataframe_backend()
assert "No supported dataframe backend found." in str(excinfo.value)
Expand All @@ -66,30 +79,45 @@ def test_get_default_dataframe_backend_error():
@pytest.mark.parametrize(
"objects, expected_backend",
[
([np.array([1, 2, 3])], Implementation.POLARS),
([np.array([1, 2, 3])], DEFAULT_BACKEND),
([pd.DataFrame({"a": [1, 2], "b": [3, 4]})], Implementation.PANDAS),
([pd.DataFrame({"a": [1, 2], "b": [3, 4]}), np.array([1, 2])], Implementation.PANDAS),
],
)
def test_get_native_namespace_or_default(objects, expected_backend):
namespace = get_native_namespace_or_default(*objects)
print(f"Namespace: {namespace}")
assert Implementation.from_native_namespace(namespace) == expected_backend


NAMESPACE_WITH_DEFAULT_CASES = [
([np.array([1, 2, 3])], Implementation.PANDAS, Implementation.PANDAS),
]

if POLARS_AVAILABLE:
NAMESPACE_WITH_DEFAULT_CASES.append(
([pl.DataFrame({"a": [1, 2], "b": [3, 4]})], Implementation.POLARS, Implementation.POLARS)
)


@pytest.mark.parametrize(
"objects",
[
[np.array([1, 2, 3])],
[pl.DataFrame({"a": [1, 2], "b": [3, 4]})],
],
"objects, default_backend, expected_backend",
NAMESPACE_WITH_DEFAULT_CASES,
)
def test_get_native_namespace_or_default_with_default(objects):
namespace = get_native_namespace_or_default(objects, default_backend=Implementation.POLARS)
assert Implementation.from_native_namespace(namespace) == Implementation.POLARS
def test_get_native_namespace_or_default_with_default(objects, default_backend, expected_backend):
namespace = get_native_namespace_or_default(*objects, default_backend=default_backend)
assert Implementation.from_native_namespace(namespace) == expected_backend


def test_get_native_namespace_or_default_error():
with pytest.raises(ValueError):
get_native_namespace_or_default(
pd.DataFrame({"a": [1, 2], "b": [3, 4]}),
default_backend=Implementation.POLARS,
)

if not POLARS_AVAILABLE:
return

with pytest.raises(ValueError):
get_native_namespace_or_default(
pd.DataFrame({"a": [1, 2], "b": [3, 4]}),
Expand All @@ -102,14 +130,21 @@ def test_get_native_namespace_or_default_error():
)


ALL_TO_NATIVE_CASES = [
([np.array([1, 2, 3])], np.ndarray),
([nw.from_native(pd.DataFrame({"a": [1, 2], "b": [3, 4]}))], pd.DataFrame),
([pd.DataFrame({"a": [1, 2], "b": [3, 4]})], pd.DataFrame),
]

if POLARS_AVAILABLE:
ALL_TO_NATIVE_CASES.append(
([nw.from_native(pl.DataFrame({"a": [1, 2], "b": [3, 4]}))], pl.DataFrame)
)


@pytest.mark.parametrize(
"objects, expected_type",
[
([np.array([1, 2, 3])], np.ndarray),
([nw.from_native(pd.DataFrame({"a": [1, 2], "b": [3, 4]}))], pd.DataFrame),
([nw.from_native(pl.DataFrame({"a": [1, 2], "b": [3, 4]}))], pl.DataFrame),
([pd.DataFrame({"a": [1, 2], "b": [3, 4]})], pd.DataFrame),
],
ALL_TO_NATIVE_CASES,
)
def test_all_to_native(objects, expected_type):
native_objects = all_to_native(*objects)
Expand Down
Loading