Visitar URL original
feat: Improve local dev experience with file-aware hooks and auto parallelization by franciscojavierarceo · Pull Request #5956 · feast-dev/feast · GitHub
Skip to content

feat: Improve local dev experience with file-aware hooks and auto parallelization #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 8 commits into from
Feb 13, 2026
Merged

feat: Improve local dev experience with file-aware hooks and auto parallelization #5956

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
82ae109
feat: Improve local dev experience with file-aware hooks and auto par…
franciscojavierarceo Feb 10, 2026
d2c57c1
fix: Address review feedback on pre-commit hooks
franciscojavierarceo Feb 10, 2026
6cf622e
fix: Restore --dist loadgroup to preserve xdist_group markers
franciscojavierarceo Feb 10, 2026
c29bf56
Merge branch 'master' into feat/improve-local-dev-experience
franciscojavierarceo Feb 12, 2026
a7b03b5
Update Makefile
franciscojavierarceo Feb 12, 2026
cd398ca
Update Makefile
franciscojavierarceo Feb 12, 2026
7f10bcc
fix: Use --dist loadgroup in test-python-integration-parallel
franciscojavierarceo Feb 12, 2026
13dc090
chore: Remove unused format-python-files and lint-python-files targets
franciscojavierarceo Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,31 @@ default_stages: [commit]
repos:
- repo: local
hooks:
- id: format
name: Format
# File-aware format hook - only runs on changed Python files
# Runs both ruff check --fix and ruff format
- id: format-files
name: Format Changed Files
stages: [commit]
language: system
entry: make format-python
pass_filenames: false
- id: lint
name: Lint
types: [python]
entry: bash -c 'uv run ruff check --fix "$@" && uv run ruff format "$@"' --

@devin-ai-integration devin-ai-integration Bot Feb 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 && in format-files pre-commit hook skips ruff format when unfixable lint violations exist

The format-files pre-commit hook entry uses && to chain ruff check --fix and ruff format. When ruff check --fix encounters lint violations that cannot be auto-fixed, it returns exit code 1, and the && operator prevents ruff format from executing. This means files with unfixable lint issues will never be auto-formatted.

Root Cause and Impact

The entry at .pre-commit-config.yaml:13 is:

entry: bash -c 'uv run ruff check --fix "$@" && uv run ruff format "$@"' --

ruff check --fix returns exit code 1 when violations remain after applying all available auto-fixes (e.g., rules that have no auto-fix available). The && operator short-circuits, so ruff format is never invoked.

Notably, the corresponding format-python-files Makefile target at Makefile:64-65 correctly uses ; (semicolons) to separate the commands, ensuring ruff format always runs regardless of ruff check --fix's exit code:

		uv run ruff check --fix $(FILES); \
		uv run ruff format $(FILES); \

Impact: When a developer commits Python files that have unfixable lint violations (which is common — many ruff rules are not auto-fixable), the formatting step is silently skipped. The developer's files won't be auto-formatted, defeating the purpose of the format hook.

Suggested change
entry: bash -c 'uv run ruff check --fix "$@" && uv run ruff format "$@"' --
entry: bash -c 'uv run ruff check --fix "$@"; uv run ruff format "$@"' --
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

pass_filenames: true

# File-aware lint hook - only runs on changed Python files
# Runs both ruff check and ruff format --check
- id: lint-files
name: Lint Changed Files
stages: [commit]
language: system
entry: make lint-python
pass_filenames: false
types: [python]
entry: bash -c 'uv run ruff check "$@" && uv run ruff format --check "$@"' --
pass_filenames: true

# Conditional template hook - only runs when template files or roadmap change
- id: template
name: Build Templates
stages: [commit]
language: system
files: ^infra/templates/|\.jinja2$|^docs/roadmap\.md$
entry: make build-templates
pass_filenames: false
22 changes: 21 additions & 1 deletion Makefile
View file
Open in desktop
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,31 @@ format-python: ## Format Python code
uv run ruff check --fix sdk/python/feast/ sdk/python/tests/
uv run ruff format sdk/python/feast/ sdk/python/tests/

# File-aware format (for use with pre-commit, accepts file args)
format-python-files: ## Format specified Python files
@if [ -n "$(FILES)" ]; then \
uv run ruff check --fix $(FILES) && \
uv run ruff format $(FILES); \
else \
echo "Usage: make format-python-files FILES='file1.py file2.py'"; \
fi


lint-python: ## Lint Python code
uv run ruff check sdk/python/feast/ sdk/python/tests/
uv run ruff format --check sdk/python/feast/ sdk/python/tests/
uv run bash -c "cd sdk/python && mypy feast"

# File-aware lint (for use with pre-commit, accepts file args)
lint-python-files: ## Lint specified Python files
@if [ -n "$(FILES)" ]; then \
uv run ruff check $(FILES) && \
uv run ruff format --check $(FILES); \
else \
echo "Usage: make lint-python-files FILES='file1.py file2.py'"; \
fi


# New combined target
precommit-check: format-python lint-python ## Run all precommit checks
@echo "✅ All precommit checks passed"
Expand Down Expand Up @@ -209,7 +229,7 @@ test-python-integration-local: ## Run Python integration tests (local dev mode)
HADOOP_HOME=$$HOME/hadoop \
CLASSPATH="$$( $$HADOOP_HOME/bin/hadoop classpath --glob ):$$CLASSPATH" \
HADOOP_USER_NAME=root \
uv run python -m pytest --tb=short -v -n 8 --color=yes --integration --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \
uv run python -m pytest --tb=short -v -n auto --color=yes --integration --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \
-k "not test_lambda_materialization and not test_snowflake_materialization" \
-m "not rbac_remote_integration_test" \
--log-cli-level=INFO -s \
Expand Down
3 changes: 3 additions & 0 deletions sdk/python/pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ markers =
rbac_remote_integration_test: RBAC and remote functionality tests
integration: Integration tests (slower, requires services)
benchmark: Benchmark tests
slow: Tests taking >30 seconds
cloud: Tests requiring cloud credentials
local_only: Tests that run entirely locally

timeout = 300
timeout_method = thread
Expand Down
Loading