Visitar URL original
fix: Fix mypy TorchTensor type alias error by nithin42 · Pull Request #6712 · feast-dev/feast · GitHub
Skip to content

fix: Fix mypy TorchTensor type alias error #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyejare merged 2 commits into from
Aug 10, 2026
Merged

fix: Fix mypy TorchTensor type alias error #6712

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeb10bc
fix: Fix mypy TorchTensor type alias error
nithin42 Aug 7, 2026
a0c040f
fix: remove redundant `import torch` under TYPE_CHECKING block
nithin42 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: remove redundant import torch under TYPE_CHECKING block 
The bare `import torch` statement inside the `if TYPE_CHECKING:` branch
was superseded by `from torch import Tensor as TorchTensor` on the
following line. Since `TorchTensor` is the only torch symbol referenced
in type annotations, the standalone module import is unnecessary and
can be dropped without affecting runtime or static-analysis behaviour.

Addresses nitpick raised in code review.

Signed-off-by: Nithin <kumbam.nithingoud@gmail.com>
  • Loading branch information
@nithin42
nithin42 committed Aug 10, 2026
commit a0c040ffa6468eb0af600ef416e768a355875183
1 change: 0 additions & 1 deletion sdk/python/feast/online_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
from feast.value_type import ValueType

if TYPE_CHECKING:
import torch
from torch import Tensor as TorchTensor
else:
TorchTensor = Any
Expand Down
Loading