Visitar URL original
fix: Fix mypy TorchTensor type alias error by nithin42 · Pull Request #6712 · feast-dev/feast · GitHub
Skip to content

fix: Fix mypy TorchTensor type alias error #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyejare merged 2 commits into from
Aug 10, 2026
Merged

fix: Fix mypy TorchTensor type alias error #6712

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeb10bc
fix: Fix mypy TorchTensor type alias error
nithin42 Aug 7, 2026
a0c040f
fix: remove redundant `import torch` under TYPE_CHECKING block
nithin42 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Fix mypy TorchTensor type alias error 
Fix the TypeAlias annotation of TorchTensor in the fallback branch of online_response.py to stop mypy from treating it as a variable and raising 'not valid as a type'.

Fixes #5563

Signed-off-by: Nithin <kumbam.nithingoud@gmail.com>
  • Loading branch information
@nithin42
nithin42 committed Aug 10, 2026
commit eeb10bc817adc3b00b5f3ea7a661c58df90d2815
7 changes: 3 additions & 4 deletions sdk/python/feast/online_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

import uuid as uuid_module
from typing import TYPE_CHECKING, Any, Dict, List, Optional, TypeAlias, Union
from typing import TYPE_CHECKING, Any, Dict, List, Optional, Union

import pandas as pd
import pyarrow as pa
Expand All @@ -26,10 +26,9 @@

if TYPE_CHECKING:
import torch

@jyejare jyejare Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must not be needed anymore.


TorchTensor: TypeAlias = torch.Tensor
from torch import Tensor as TorchTensor
else:
TorchTensor: TypeAlias = Any
TorchTensor = Any

TIMESTAMP_POSTFIX: str = "__ts"

Expand Down