Visitar URL original
Add supported Luci builders for packages repo by keyonghan · Pull Request #184 · flutter/packages · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions dev/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
This directory contains resources that the Flutter team uses during
the development of packages.

## Luci builder file
`packages_try_builders.json` contains the supported luci try builders
for packages. It follows format:
```json
{
"builders":[
{
"name":"xxx",
"repo":"packages"
}
]
}
```
This file will be mainly used in [`flutter/cocoon`](https://github.com/flutter/cocoon)
to update luci task statuses of packages pre-submit tests.

8 changes: 8 additions & 0 deletions dev/packages_try_builders.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the same paths in all the repos? e.g in the engine repo we are using ci/dev/... additionally let's use just try_builders.json to make the recipes code more generic.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use the same path as well.
For engine, as suggested by Yuqian, I saved it to ci/dev.
For sdk, we already have dev. I am not sure if it is okay/good to create a ci from root.
For packages, no dev or ci at all. I guess we can create either way.
For cocoon, it is now in dev, but up to change.

So, it is engine and sdk. what do you think?

@godofredoc godofredoc Aug 5, 2020 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\cc @goderbauer is it ok to add a new top level folder called dev in this repo? this is to use the same path for builder configurations across repos.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a dev folder in this repo sounds good.

"builders":[
{
"name":"fuchsia_ctl",
"repo":"packages"
}
]
}