Repository navigation
JS: Fix Map content flow - #22781
Open
MathiasVP wants to merge 3 commits into
Open
JS: Fix Map content flow#22781MathiasVP wants to merge 3 commits into
Map content flow#22781MathiasVP wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The replacement drops flow from existing entries() summaries that still produce Member[0/1] paths.
1 open finding
What changed in this PR
Fixes JavaScript data flow through Map constructor entries.
Changes:
- Models indexed elements in entry arrays.
- Adds a constructor-flow regression test.
- Updates consistency expectations.
| File | Description |
|---|---|
Maps.qll |
Updates Map constructor flow paths. |
tst.js |
Tests value flow from constructor entries. |
DataFlowConsistency.expected |
Updates expected consistency output. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+23
to
+24
| input = | ||
| "Argument[0]." + ["ArrayElement", "SetElement", "IteratorElement"] + ".ArrayElement[0]" and |
Contributor
Author
There was a problem hiding this comment.
Hmm @asgerf this sounds right. What do you say here?
Contributor
|
Thanks for flagging this. I have an alternative fix here that I'd like to pursue instead as |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #22765. I'm not sure if there is some subtle thing that both me and Copilot are missing?