Visitar URL original
JS: Fix `Map` content flow by MathiasVP · Pull Request #22781 · github/codeql · GitHub
Skip to content

JS: Fix Map content flow #22781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MathiasVP wants to merge 3 commits into from
+13 −2
Closed

JS: Fix Map content flow #22781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd0ebd8
JS: Add a failing test.
MathiasVP Oct 7, 2026
16d25ff
JS: Fix map flow.
MathiasVP Oct 7, 2026
6f38136
JS: Accept test changes.
MathiasVP Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions javascript/ql/lib/semmle/javascript/internal/flow_summaries/Maps.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ class MapConstructor extends SummarizedCallable::Range {
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
preservesValue = true and
(
input = "Argument[0]." + ["ArrayElement", "SetElement", "IteratorElement"] + ".Member[0]" and
input =
"Argument[0]." + ["ArrayElement", "SetElement", "IteratorElement"] + ".ArrayElement[0]" and
Comment on lines +23 to +24

@MathiasVP MathiasVP Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm @asgerf this sounds right. What do you say here?

output = "ReturnValue.MapKey"
or
input = "Argument[0]." + ["ArrayElement", "SetElement", "IteratorElement"] + ".Member[1]" and
input =
"Argument[0]." + ["ArrayElement", "SetElement", "IteratorElement"] + ".ArrayElement[1]" and
output = "ReturnValue.MapValue"
or
input = ["Argument[0].WithMapKey", "Argument[0].WithMapValue"] and
Expand Down
1 change: 1 addition & 0 deletions javascript/ql/test/library-tests/FlowSummary/DataFlowConsistency.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ postIsInSameCallable
reverseRead
| tst.js:109:11:113:3 | [dynamic parameter array] | Origin of readStep is missing a PostUpdateNode. |
| tst.js:267:28:267:31 | map3 | Origin of readStep is missing a PostUpdateNode. |
| tst.js:305:30:305:43 | constructedMap | Origin of readStep is missing a PostUpdateNode. |
argHasPostUpdate
postWithInFlow
viableImplInCallContextTooLarge
Expand Down
8 changes: 8 additions & 0 deletions javascript/ql/test/library-tests/FlowSummary/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,3 +299,11 @@ function m18() {
sink(dynamicParam1("safe", ...[source()])); // NOT OK
sink(dynamicParam1(source(), ...["safe"])); // OK
}

function m19() {
const constructedMap = new Map([["key", source()]]);
for (const [key, value] of constructedMap) {
sink(key); // OK
sink(value); // NOT OK
}
}
Loading