Repository navigation
fix(engine): reject duration values that wrap time.Duration - #32841
Open
weirong-ui wants to merge 1 commit into
Open
weirong-ui wants to merge 1 commit into
weirong-ui wants to merge 1 commit into
Conversation
Signed-off-by: weirong-ui <2771986015@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
asDurationwraps toMinInt64instead of returning an error at the upperfloat boundary:
float64(math.MaxInt64)rounds up to 2^63, so forseconds == maxDurationSecondsFloatthe computednanosequals 2^63, passesthe
>check, andtime.Duration(nanos)wraps toMinInt64. Both helpers gothrough
asDuration.Use
>=for the upper bound. The lower bound stays<because -2^63 isrepresentable and is a valid duration. Added boundary cases to
TestDurationHelpers.Special notes for your reviewer:
Found this while reading the overflow guard added in #31695. The new cases only
pin down the boundary; values below it are unchanged.
If applicable:
docs neededlabel should be applied if so)