Visitar URL original
fix(engine): reject duration values that wrap time.Duration by weirong-ui · Pull Request #32841 · helm/helm · GitHub
Skip to content

fix(engine): reject duration values that wrap time.Duration #32841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weirong-ui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(engine): reject duration values that wrap time.Duration #32841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/engine/funcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,8 @@ func durationFromSecondsFloat(seconds float64) (time.Duration, error) {
return 0, fmt.Errorf("duration seconds overflow: %v", seconds)
}
nanos := seconds * float64(time.Second)
if nanos > float64(math.MaxInt64) || nanos < float64(math.MinInt64) {
// float64(math.MaxInt64) rounds up to 2^63, which wraps when converted.
if nanos >= float64(math.MaxInt64) || nanos < float64(math.MinInt64) {
return 0, fmt.Errorf("duration nanoseconds overflow: %v", nanos)
}
return time.Duration(nanos), nil
Expand Down
9 changes: 9 additions & 0 deletions pkg/engine/funcs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,11 @@ func TestDurationHelpers(t *testing.T) {
tpl: `{{ durationSeconds . }}`,
vars: maxDurationSecondsFloat + 0.5,
expect: `0`,
}, {
name: "durationSeconds float at upper boundary returns 0",
tpl: `{{ durationSeconds . }}`,
vars: maxDurationSecondsFloat,
expect: `0`,
}, {
name: "durationSeconds float underflow returns 0",
tpl: `{{ durationSeconds . }}`,
Expand Down Expand Up @@ -425,6 +430,10 @@ func TestDurationHelpers(t *testing.T) {
name: "mustToDuration float overflow",
tpl: `{{ mustToDuration . }}`,
vars: maxDurationSecondsFloat + 0.5,
}, {
name: "mustToDuration float at upper boundary",
tpl: `{{ mustToDuration . }}`,
vars: maxDurationSecondsFloat,
}, {
name: "mustToDuration float underflow",
tpl: `{{ mustToDuration . }}`,
Expand Down
Loading