[pull] master from owncloud:master - #151

Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v9...v10)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: '10'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…12295)

* disallow loading account if it doesn't support spaces - this is for migration from 6-7 when an old oc10 account is in the config

* refactored the check for spaces support to use creds as 6.0 writes bogus value for supportsSpaces to config

* when we have a config with account that does not support spaces, remove the entry associated with the account uuid from the Credentials settings group along with the account overall
also possible fix for crash related to having an existing oauth instance when we get a notice to log the user in again. needs final testing

* Fix credentials key querying

* fix the tests - the caps had no entry for spaces

* removing QStringLiterals and added explanation for corner case when asking user to reauth

---------

Co-authored-by: Erik Verbruggen <erik@verbruggen.consulting>

* removed checks of supportsSettings in accountSettings
removed the supportsSpacedChanged signal from the account state and cleaned out any supportsSpaces checks from the FolderDelegate.
confirmed the folder button still works as it should (eg disabled when all folders are synced, enabled when there is something missing)

* finished cleaning the files in this commit. next step: kill the quotaInfo impl entirely

* eliminated all traces of quotainfo.cpp
deprecated Theme::quotaFolder as it is associated with the quotainfo

* AccountState::supportsSpaces is now gone.

* address review comments

wait for file in sync folder to sync

* chore: remove systray context menu workarounds

* fix: drop status menu item from system tray menu

* fix: remove "recent changes" from systray menu

* fix: remove accounts from system tray menu

* fix: remove timer to update system tray menu

* fix: remove global sync handling form system tray menu

* fix: cut all dynamic processing from the system tray menu

* fix: remove system tray tool tips

* fix: drop ProgressDispatcher and slots for account updates - we only need to react to updates on folder basis

* fix: cleanup tray status computation and bring back account status notification

* chore: fixing comments and remove [[nodiscard]]

* fix: adust constness and naming

---------

Co-authored-by: modSpike <lisa.reese@kiteworks.com>

…unt (#12289)

* updated remaining todo's for dc-112 to new story id 128

* updated the abstract creds to take both an account and parent
deleted several outdated functions from the base and subs, most notably the creds->setAccount (it should only come from the ctr)
updated the tests to use the new scheme

* fixed the tests.

* get rid of the "save credentials" switches on account save routines. the creds persist to the keychain as needed so these args on account related save are just noise.

* mostly test refactoring to cover the new reqs for creating account before creds (as the creds take account in ctr)
I also found the source of almost endless asserts on the account->davUser which should not be empty. That was accessed in debug output BEFORE the value was set :/ davUser is moving to the acct ctr asap but that was such a sneaky failure.

* tests finally pass

* start dealing with the setDavUser

* the account url and davUser are now immutable after construction
also added a new todo for getting rid of more oc10 stuff

* Finally updated the Account::id to reflect what it actually is: the account group index which is used to write the settings
also removed the deprecation flag as we need this into the future.
also renamed the associated functions in the account manager to reflect the index based nature of the value

* final cleanup

* fixed failing testconnectionvalidator

* fixed major bug that the credentials were not persisted after creating a new account, which caused a re-auth request when restarting the app (only the first time after creating the account. after reauth everything is cool)
now it works correctly so the account is created, and properly reloaded with the existing creds on restart.

add wait for file to sycn step

* [DC-146] Fix VFS checkbox in folder wizard

On the last page of the folder wizard, there is a checkbox to
select/deselect VFS. By default this is checked. The bug was that
after unchecking this checkbox, it could not be checked again.
This has now been fixed.

* Move checkbox handling to a slot

* [DC-166] Disable selective-sync when VFS is forced

Previously the checkbox to deselect VFS was not shown when VFS was
forced. This also caused the selective sync widget to be enabled. This
is now fixed: the checkbox is shown (and checked) when VFS is
availabled, but disabled when VFS is forced. This leaves it in the
checked state, but the user cannot deselect it.

---------

Co-authored-by: modSpike <lisa.reese@kiteworks.com>

use requests instead of urllib request

…ownloading syncstate.py (#12323)

use raw.githubusercontent.com instead of raw.github.com

* Remove oc10 specific sharing code

* Remove unused SocketAPI methods

* Remove "Manage public links" from shell context menu

All sharing goes over the Web UI.

* Inline single-use method

`processShareRequest` was previously called from multiple place, but now
from only 1 method, so inline it.

* Remove more unused code

* chore: remove EMAIL_PRIVATE_LINK_MENU_TITLE

* Windows: do not create a path for a named pipe

* Incorporate review feedback

---------

Co-authored-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

Most importantly: the `WizardPageValidator` has virtual functions but
a non-virtual destructor.

This reverts commit 81fb886.

This reverts commit 40aed09.

* Check `AccountState` and `Account` pointers before usage

* More pointer checks

* fix: deprecate no longer used theming options

* fix: revert changes in FolderMan::unsupportedConfiguration

* chore: doc legacy dav usage in ConnectionValidator

* fix: deprecate gitSHA1

* fix: adapt deprecation message

---------

Co-authored-by: modSpike <lisa.reese@kiteworks.com>

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.3.0 to 7.0.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@ece7cb0...5fda3b9)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

added help action to ... menu

also killed a bit of dead code I ran across randomly

…from connection validator routines (#12619)

* first pass for moving the FetchServerSettingsJob to AccountState

it leaks at the moment as there are issues with deleting the job on finished signal.

that needs to be fixed in the job by ensuring the "asyncUpdates" are finished before the finished signal is emitted.

alternately can call those extra operations from the AccountState but I think having it all in the job is simpler.

* this works but may have side effects

committing it for discussion with cohort

* works now but..

this is a very questionable impl. The core problem is not being able to simply delete the settings job, in tandem with questionable "need" to have that be null by the time the folders are enqueued.

will discuss next week and clean it up

* lots of cleanup

also refined the caps/user info/avatar/appprovider retrieval to only happen on start and re-auth.

needs a bit more testing then hoping it's done

* final cleanup and refinement

also renamed the very misleading FetchServerSettingsJob to FetchServerSettingsRunner.

by unanimous decision we just killed the previous caps related tests in ConnectionValidator since it is no longer in play there.

* added changelog

* grrrr

…se of Resources wherever possible (#12625)

* added handling for multi-size icons

also the pathForTheme was completely busted so branded tray icons were broken.

fixed that too in this round

* replaced Resources::getCoreIcon with IconResources::getCoreIcon

* replaced Resources::themeUniversalIcon with IconResources::getUniversalIcon

concrete updates to the non-oc themes under separate cover

* replaced Resources::buildAvatar with IconResources::buildAvatar

* got rid of the remaining Resources functionality

it has been replaced mostly in IconResources but also using simpler checks where appropriate.

the only thing that remains is the CoreImageProvider which is needed for QmlResources for now, and a single helper that imo is not needed for the rest of the codebase, but remains to support the qml stuff.

* adding changelog

dropping support for OWNCLOUD_FORCE_DARK_MODE which should be clearly stated in release notes

* missed one

removed dead function decl

* updater needed new IconResources

also killed a few dead includes and commented code

Co-authored-by: owncloud-translations-bot[bot] <274778013+owncloud-translations-bot[bot]@users.noreply.github.com>
Co-authored-by: Erik Verbruggen <erik.verbruggen@kiteworks.com>

put the Theme::urlActions() in menu

this makes more sense than putting them in a button

Co-authored-by: owncloud-translations-bot[bot] <274778013+owncloud-translations-bot[bot]@users.noreply.github.com>

added tooltip role for folder items

it returns folder::displayName

* removed dead Theme::syncStateIconName

* killed the qml related Theme::create function

* updated the theme.h includes and fixed fallout elsewhere.

* updated the text color impl 

* completely overhauled the docs in theme.h

* replaced icons with names in theme

* renamed IconResources::getUniversalIcon to IconResources::getBrandingIcon for more clarity

* adapted the url actions handling to not assume any subpath for the icon(s). the theme should return any subpath in the tuple's icon name.

* changelog: add 7.1.0 release notes

Co-authored-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: modSpike <lisa.reese@kiteworks.com>

* feat: v7.1.0-rc.4 (#12544) release notes

* feat: add v7.1.0 (#12554) changelog

* changelog: fIx calens validation errors and duplicates in 7.1.0 fragments

- Change Feature: to Enhancement: in 12233, 12367, 12399 (invalid type)
- Shorten titles in 12487 and 12336 to stay within 80-char limit
- Remove 12093 and 12245 (already released in 6.0.0)
- Re-scope 12305 to the #12144 work only (checkbox fix already in 6.0.1)
- Drop stale "macOS 12" sentence from 12270 (minimum is 13 since 6.0.0)
- Regenerate CHANGELOG.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: modSpike <lisa.reese@kiteworks.com>

* chore: add changelog for PR #12597 (#12623)

* docs: regenerate changelog

made the "More" label visible on ... button

…2635)

* switched to using icon again

* went back to fusion style on windows due to bugs in win11 style

* alias is available and it's stored in the config

* did some visual tweaking of the toolbar button sizes (set min width to silver ratio against height, hid separator before ... button)

* added the alias editor action + input dialog

* I also removed dead stuff in account

* added changelog

Co-authored-by: owncloud-translations-bot[bot] <274778013+owncloud-translations-bot[bot]@users.noreply.github.com>

…nal teardown routines (#12641)

hopefully fixed incomplete aborts in various scenarios

for removing folders permanently (either from remove folder sync or remove whole account) wipeForRemoval now waits for any running sync to finish before completing the teardown.

For application shutdown, which triggered an assert on isSyncRunning in Folder dtr, folderman now aborts any running sync (previously it just let them run!) and waits for completion before doing the final folder cleanup.

Also renamed FolderMan::unloadAndDeleteAllFolders to FolderMan::shutdown (for more clarity re: when it should be used)

Co-authored-by: owncloud-calens-bot[bot] <276982735+owncloud-calens-bot[bot]@users.noreply.github.com>

…discovery (#12645)

the folder should always be responsible for updating it's state. Add new comprehensive handler in Folder for updating selective sync which ensures remote discovery is triggered.

…color scheme changes (#12642)

* new color manager with ownership in Application

* killing ActivitySettings since it is obsolete

* had to refactor a bit of old logic in the accountViewController to allow updating the connection state icon

* fixed selective sync and folder error items by implementing item data()

also did a small update on accountState handling: if I logged out of an account before it finished connecting, bad things happened related to fetching server settings. Now it's stable and better behaved.

…app providers, other settings changes (#12649)

* basic polling added for fetching server settings

* added context to timer and fixed function reachability

* always fetchServerSettings on re-auth

* updated the changelog to cover both pr's

* added some comments

…f play (#12651)

block the strangely ever present toolbar menu

disable the toggleViewAction too for good measure.

)

can't reproduce the crash but the error view and associated items and model have some very obvious problems, most notably using a raw pointer for item _folder member. That's now a QPointer and nullptr checks have been added in the hottest spots to hopefully eliminate crash potential.

the folderRemoved and folderListChanged handlers needed improvement as well.

activity view also got some similar updates.

Fixed loading folder images on account creation. Removed some now irrelevant code and verified everything still works wrt loading from config and changing image while running (for ocis only)

* fix crash on what I presume was attempt to paint the error table

this happened after deleting the account. presumably the folder pointer was not yet deleted (which sort of makes sense - the teardown routines are somewhat separate between accounts and folders).

Co-authored-by: owncloud-calens-bot[bot] <276982735+owncloud-calens-bot[bot]@users.noreply.github.com>

Co-authored-by: owncloud-translations-bot[bot] <274778013+owncloud-translations-bot[bot]@users.noreply.github.com>

eliminated the journalDb accessor

also fixed db journal functions that take pointers instead of refs - it's a faulty approach since they fail with nullptr, refs are the way to go

* more cleanup

for unknown reasons Folder was often using journalDb() instead of the member

Also fixed a mess related to const correctness for ownsql + ensuring fillFileRecordFromGetQuery takes the SqlQuery by *const* ref

eliminated selective sync "types" in the db as the only type used effectively was SelectiveSyncBlacklist. This naming is easily confused with error blacklist so I refactored public interfaces with new naming = selectiveSyncExclusions.