Visitar URL original
Eval: run a code string by kelilipan · Pull Request #138 · javascript-tutorial/id.javascript.info · GitHub
Skip to content

Eval: run a code string - #138

Merged
yoga1234 merged 3 commits into
javascript-tutorial:masterfrom
kelilipan:eval
Oct 7, 2020
Merged

Eval: run a code string#138
yoga1234 merged 3 commits into
javascript-tutorial:masterfrom
kelilipan:eval

Conversation

@kelilipan

@kelilipan kelilipan commented Oct 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@javascript-translate-bot
javascript-translate-bot requested a review from a team October 6, 2020 15:24
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 6, 2020
Open
yoga1234
yoga1234 reviewed Oct 6, 2020
View reviewed changes
Comment thread 1-js/99-js-misc/02-eval/1-eval-calculator/solution.md Outdated
yoga1234
yoga1234 reviewed Oct 6, 2020
View reviewed changes
Comment thread 1-js/99-js-misc/02-eval/article.md Outdated
yoga1234
yoga1234 requested changes Oct 6, 2020
View reviewed changes

@yoga1234 yoga1234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada beberapa komentar gan..

@javascript-translate-bot

javascript-translate-bot commented Oct 6, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@kelilipan

kelilipan commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

resolved by 7043802 gan

@kelilipan

kelilipan commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a team October 6, 2020 16:35
babul28
babul28 reviewed Oct 7, 2020
View reviewed changes
Comment thread 1-js/99-js-misc/02-eval/article.md Outdated
Comment thread 1-js/99-js-misc/02-eval/article.md Outdated
Comment thread 1-js/99-js-misc/02-eval/article.md Outdated
@kelilipan

kelilipan commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

/done

@yoga1234
yoga1234 merged commit b5ad8c6 into javascript-tutorial:master Oct 7, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 7, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoga1234 yoga1234 yoga1234 requested changes
+1 more reviewer
@babul28 babul28 babul28 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kelilipan @javascript-translate-bot @yoga1234 @babul28