build: DEX code optimization - #5032

Regarding proguard.cfg, should it also be removed when adding the new file? It doesn't appear to be used anywhere in the project, unless I'm missing something @jesmrec

Regarding proguard.cfg, should it also be removed when adding the new file? It doesn't appear to be used anywhere in the project, unless I'm missing something @jesmrec

you're right, it's not referenced apart of very old and not maintained. The current file should be enough. Removing it.

Extra updates:

• AppRegistryProvider class does not have @JsonClass annotation. It is serialized to JSON by KotlinJsonAdapterFactory and stored as a plain string in the app_providers Room column. Without this rule, R8 renames its fields, making stored JSON unstable across releases and causing app providers to silently disappear after an app update.

• Replace all rules about classes extending androidx.preference.PreferenceFragmentCompat for a wildcard, so that, any newly created class extending will be also covered by the rule.

• The four custom view keep rules in proguard-rules.pro were deleted because the Android build tools (AAPT) already generate exactly those rules automatically by scanning the layout XML files. Removed to avoid that duplication

• The Moshi rule was changed from -keep @JsonClass class * { *; } to -keepnames @JsonClass class *. The old rule prevented R8 from removing any member of every Moshi model class, blocking the shrinking that was the whole point of enabling R8; the new rule only prevents renaming, which is all that's actually needed to keep JSON field mapping working.

New update:

• Classes inside of com.owncloud.android.lib.common.http.logging were data classes with no @JsonClass, so the existing -keepnames @JsonClass rule doesn't cover them.