Visitar URL original
Resume Parked Groups on a Recorded Answer and Close Loop-Skill Gaps by ptr727 · Pull Request #4045 · ptr727/ProjectTemplate · GitHub
Skip to content

Resume Parked Groups on a Recorded Answer and Close Loop-Skill Gaps - #4045

Merged
ptr727 merged 7 commits into
developfrom
feature/loop-skill-resume-rules
Nov 11, 2026
Merged

ptr727 merged 7 commits into
developfrom
feature/loop-skill-resume-rules

Conversation

@ptr727

@ptr727 ptr727 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes four issues in the backlog-burndown, decision-triage, and session-handoff skills. Each edit is in the .agents/skills/ source and the generated trees are regenerated.

Closes on promotion: #4012, #3830, #2669, #4023

Verification

  • scripts/build_dist.py --check: generated trees current.
  • tests/test_build_dist.py: all 99 pass.
  • scripts/repo_gate.py: exit 0.
  • Prose gate over the branch diff: no violations.
  • Seven recorded local strict passes. Their findings on text this change wrote were fixed in this pull request's commits.

Local Findings Declined

  • .agents/skills/backlog-burndown/SKILL.md "Promoting", class introduced: a hold on work left on an answered issue with no parked group. Declined because such an issue closes only at the promotion, so the hold restores the closing test Resume a Parked Group on an Answered Decision, and End Decision Triage on a Skipped Question #4012 item 1 removes. An answer saying the fix must land first is an answer about the promotion, which is followed.
  • .agents/skills/session-handoff/SKILL.md "Closing a Session" step 4, class introduced: a check for unpushed commits before removing the hub clone. Declined because no step commits in that clone, and repo-worktree's by-hand removal carries no such check.
  • .agents/skills/backlog-burndown/SKILL.md "Ranking", class introduced: a question-only issue joined to a group has no closing path when the answer ends the work. Declined because a joined issue is one of the group's issues, and "Parking Instead of Asking" has the worker close an issue the answer drops, citing the answer.

🤖 Generated with Claude Code

ptr727 and others added 3 commits November 10, 2026 16:07
Key the backlog-burndown resume and the promotion hold on a recorded
answer rather than on the decision issue closing, keeping the deferred
and agent-safety holds. Present each decision-triage question once and
report a skipped one as still open. Accept a standalone clone tip at or
behind the pull request head, as repo-worktree does.

Stop the away-mode "Invoking It" bullet stating a resume rule of its
own. Count CI on a platform runner as verification for a platform lane.
Add a removal step for the session's hub clone, a re-check of deferred
issues whose condition is checkable state, and a report line on the
away-run endings that cannot dispatch a promotion worker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Count the reason an item left the decision queue as its answer, so an
overtaken decision does not hold a promotion for good. Put decision back
when a lifted deferral leaves its question undetermined. Return lifted
issues in the planner's round plan, and limit the session-end report
line to a session that can still write one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restore decision in the same act at triage when a lifted deferral's
question is still undetermined, and close a lifted issue that held only
a settled question. State the promotion hold's test where the promotion
worker reads it. Limit the platform CI sentence to an issue that job
verifies, and name only the worker owed at an ending in its report line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 11, 2026 00:25
@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head d336c001563c5ac46805a4cffe041c25edf6fb89, the content this pull request carries at that commit against develop, and it recorded 5 findings.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9b277fc and 1ed00b4.

Files ignored due to path filters: 9

  • .claude-plugin/fleet-skills/.source-digests/backlog-burndown is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/decision-triage is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/session-handoff is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/decision-triage/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/session-handoff/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .github/skills/backlog-burndown/SKILL.md is excluded by !.github/skills/**
  • .github/skills/decision-triage/SKILL.md is excluded by !.github/skills/**
  • .github/skills/session-handoff/SKILL.md is excluded by !.github/skills/**
Files selected for processing: 3

  • .agents/skills/backlog-burndown/SKILL.md
  • .agents/skills/decision-triage/SKILL.md
  • .agents/skills/session-handoff/SKILL.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Let a lifted question-only issue join its parked group's issues rather
than closing it on judgment. Hold a promotion until develop carries work
a decision settled with no parked group. Tie the ending report line to a
worker the run owes, and send a lifted question through the history
check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Active moderate and critical findings remain in the backlog, decision-triage, and session-handoff skills, including unsafe issue closure, premature promotion, incorrect worker reporting, stale decision requeueing, and destructive cleanup gaps.

5 open issues
What changed in this PR

This PR updates the fleet's backlog-burndown, decision-triage, and session-handoff skills to improve recorded-answer handling, deferred issue checks, platform verification, cleanup procedures, and generated distribution synchronization.

Changes:

  • Resumes parked work from recorded answers and rechecks deferred issues.
  • Clarifies platform CI verification, standalone clone cleanup, and hub-clone removal.
  • Adds away-run reporting for missed promotion workers and regenerates distributed skill trees.
File Description
.github/​skills/​session-handoff/​SKILL.md Generated GitHub Copilot distribution of the session-handoff skill changes.
.github/​skills/​decision-triage/​SKILL.md Generated GitHub Copilot distribution of the decision-triage skill changes.
.github/​skills/​backlog-burndown/​SKILL.md Generated GitHub Copilot distribution of the backlog-burndown skill changes.
.claude-plugin/​fleet-skills/​skills/​session-handoff/​SKILL.md Generated Claude distribution of the session-handoff skill changes.
.claude-plugin/​fleet-skills/​skills/​decision-triage/​SKILL.md Generated Claude distribution of the decision-triage skill changes.
.claude-plugin/​fleet-skills/​skills/​backlog-burndown/​SKILL.md Generated Claude distribution of the backlog-burndown skill changes.
.claude-plugin/​fleet-skills/​.source-digests/​session-handoff Updates the source digest for the generated session-handoff distribution.
.claude-plugin/​fleet-skills/​.source-digests/​decision-triage Updates the source digest for the generated decision-triage distribution.
.claude-plugin/​fleet-skills/​.source-digests/​backlog-burndown Updates the source digest for the generated backlog-burndown distribution.
.agents/​skills/​session-handoff/​SKILL.md Updates canonical session-handoff rules for platform verification and hub-clone cleanup.
.agents/​skills/​decision-triage/​SKILL.md Updates canonical decision-triage rules for deferred issue rechecks and single-pass question handling.
.agents/​skills/​backlog-burndown/​SKILL.md Updates canonical backlog-burndown rules for ranking, parked-group resumption, cleanup, promotion, and away-run reporting.

Review effort: Lite

Comment thread .agents/skills/session-handoff/SKILL.md Resolved
Comment thread .agents/skills/decision-triage/SKILL.md Resolved
Hold a promotion for settled work only while the issue is open with work
left on it, so a closed question-only decision cannot hold one for good.
Count platform CI as the verification half of the platform-lane test and
leave the fix half to that test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.03%. Comparing base (9b277fc) to head (1ed00b4).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4045   +/-   ##
========================================
  Coverage    79.03%   79.03%           
========================================
  Files           37       37           
  Lines        12676    12676           
========================================
  Hits         10019    10019           
  Misses        2657     2657           
Flag Coverage Δ
python-3.13 79.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head f70f6431d0e1147ec339d50ce924f9b9c72e473b, the content this pull request carries at that commit against develop, and it recorded 5 findings.

ptr727 and others added 2 commits November 10, 2026 16:37
Delete the promotion hold on work left on an answered issue, since it
restored the closing test and an answer about the promotion is already
followed. Apply the join and rank routes only to a settled question,
state that a dispatch failure skips the owed worker, and state that the
hub clone's ignored files are caches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the rule that a question-only issue joins its resuming group out of
the lift step, so it holds from any route that records the answer and
across rounds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 1ed00b48e075ba7b7a03b4ec30fb953b952d853e, the content this pull request carries at that commit against develop, and it recorded 1 finding.

@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit 68a6563 into develop Nov 11, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/loop-skill-resume-rules branch November 11, 2026 01:13
ptr727 added a commit that referenced this pull request Nov 11, 2026
…ry Short Names, Stub Read Grant (#4054)

## Summary

Promotes burndown round 1 of the attended run of 2026-11-10 from
`develop` to `main`.

- #4047: an attested local pass keeps `coverage=local` against a round
that only carries a file table. A promotion now reads green Dependabot
manifest bumps as covered, through the new `pr_review_promotion.py`. The
promotion case also counts an attestation over direct-to-`develop`
changes and excuses byte-identical renames.
- #4045: the loop skills resume a parked group on a recorded answer,
present each question once, accept a clone tip at or behind head, and
re-check `deferred` issues whose condition is checkable. An away run's
endings that cannot dispatch a promotion worker now report that.
- #4046: every registry entry carries a required, gated `shortName`. A
changed short name fails the spec gate as a migration.
- #4044: `pull-requests: read` on each caller stub's `validate` job, the
hub half of #2354. It takes effect once the lint job declares the scope.
- #4052, #4053, #4055, from other sessions: registry and rollout-tracker
updates. They declare Python for Vantage-Config, register the Employment
repository with its short name and pin, and reconcile the HolidayLights
entry.

Fixes #3955
Fixes #3909
Fixes #3901
Fixes #3905
Fixes #4012
Fixes #3830
Fixes #2669
Fixes #4023
Fixes #4028

#2354 stays open for the lint job's grant and the downstream rollout.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants