Visitar URL original
bpo-29595: Expose max_queue_size in ThreadPoolExecutor by prayerslayer 路 Pull Request #143 路 python/cpython 路 GitHub
Skip to content

bpo-29595: Expose max_queue_size in ThreadPoolExecutor #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prayerslayer wants to merge 10 commits into from
Closed

bpo-29595: Expose max_queue_size in ThreadPoolExecutor #143

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
66c0031
expose max_queue_size in threadpoolexecutor
prayerslayer Feb 17, 2017
693689c
tests
prayerslayer Feb 18, 2017
e76e9a7
wording
prayerslayer Feb 18, 2017
c2079a7
review fixes
prayerslayer Feb 19, 2017
6103533
update docs
prayerslayer Feb 20, 2017
edcf3f9
fix whitespace
prayerslayer Feb 27, 2017
cde3edd
Merge branch 'master' into expose-max-queue-size-in-threadpoolexecutor
Oct 30, 2017
f10a6f9
Document blocking behavior
Oct 30, 2017
2338991
Add highlevel test for threadpool queue size
Oct 30, 2017
9d1a24b
Add news entry
Oct 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add highlevel test for threadpool queue size
  • Loading branch information
Nikolaus Piccolotto
Nikolaus Piccolotto committed Oct 30, 2017
commit 23389910bfffcdb83f6e8cfbe6adc044bd8a54c0
29 changes: 19 additions & 10 deletions Lib/test/test_concurrent_futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,18 +239,27 @@ def test_thread_names_default(self):
t.join()

def test_default_max_queue_size(self):

@pitrou pitrou Apr 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a higher-level test, i.e. create an executor with a non-zero queue size, submit a number of tasks larger than the queue size, and check that they all get executed in the end.

@prayerslayer prayerslayer Aug 23, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea :)

executor = futures.ThreadPoolExecutor()
self.assertEqual(executor._work_queue.maxsize, 0)
with futures.ThreadPoolExecutor() as executor:
self.assertEqual(executor._work_queue.maxsize, 0)

def test_custom_max_queue_size(self):
# test custom valid and invalid values
for i in range(-10, 10):
executor = futures.ThreadPoolExecutor(max_queue_size=i)
self.assertEqual(executor._work_queue.maxsize, i)
# provided value is forwarded without checking it
for bad_value in [None, "5", False, True, 3.14]:
executor = futures.ThreadPoolExecutor(max_queue_size=bad_value)
self.assertEqual(executor._work_queue.maxsize, bad_value)
qsize = 1
with futures.ThreadPoolExecutor(max_queue_size=qsize) as executor:
# test custom queue size was passed down
self.assertEqual(executor._work_queue.maxsize, qsize)

# test executor works with custom size
n = 10

def process_item(item):
return item + 1

@pitrou pitrou Oct 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a small sleep() here to help the queue reach its limit at some point?


fs = [executor.submit(process_item, i) for i in range(n)]
expected_results = [process_item(i) for i in range(n)]

for f in futures.as_completed(fs, timeout=10):

@pitrou pitrou Oct 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, simply, self.assertEqual(sorted(f.result() for f in futures.as_completed(...)), sorted(expected_results))

result = f.result()
self.assertTrue(result in expected_results, result)


class ProcessPoolShutdownTest(ExecutorShutdownTest):
Expand Down