Visitar URL original
bpo-29595: Expose max_queue_size in ThreadPoolExecutor by prayerslayer 路 Pull Request #143 路 python/cpython 路 GitHub
Skip to content

bpo-29595: Expose max_queue_size in ThreadPoolExecutor #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prayerslayer wants to merge 10 commits into from
Closed

bpo-29595: Expose max_queue_size in ThreadPoolExecutor #143

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
66c0031
expose max_queue_size in threadpoolexecutor
prayerslayer Feb 17, 2017
693689c
tests
prayerslayer Feb 18, 2017
e76e9a7
wording
prayerslayer Feb 18, 2017
c2079a7
review fixes
prayerslayer Feb 19, 2017
6103533
update docs
prayerslayer Feb 20, 2017
edcf3f9
fix whitespace
prayerslayer Feb 27, 2017
cde3edd
Merge branch 'master' into expose-max-queue-size-in-threadpoolexecutor
Oct 30, 2017
f10a6f9
Document blocking behavior
Oct 30, 2017
2338991
Add highlevel test for threadpool queue size
Oct 30, 2017
9d1a24b
Add news entry
Oct 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
expose max_queue_size in threadpoolexecutor
  • Loading branch information
@prayerslayer
prayerslayer committed Feb 17, 2017
commit 66c0031a08e6499486cc05db737ace0fb0a8de2d
4 changes: 2 additions & 2 deletions Lib/concurrent/futures/thread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def _worker(executor_reference, work_queue):
_base.LOGGER.critical('Exception in worker', exc_info=True)

class ThreadPoolExecutor(_base.Executor):
def __init__(self, max_workers=None, thread_name_prefix=''):
def __init__(self, max_workers=None, thread_name_prefix='', max_queue_size=0):
"""Initializes a new ThreadPoolExecutor instance.

Args:
Expand All @@ -97,7 +97,7 @@ def __init__(self, max_workers=None, thread_name_prefix=''):
raise ValueError("max_workers must be greater than 0")

self._max_workers = max_workers
self._work_queue = queue.Queue()
self._work_queue = queue.Queue(maxsize=max_queue_size)
self._threads = set()

@DimitrisJim DimitrisJim Feb 18, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxsize is the sole arg to the initializer of Queue so you could just supply max_queue_size since it's also pretty descriptive.

@prayerslayer prayerslayer Feb 19, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the sole arg to the initializer

What if this changes? Is it then still safe to just pass max_queue_size as positional argument?

self._shutdown = False
self._shutdown_lock = threading.Lock()
Expand Down