Visitar URL original
gh-158592: Skip reallocation when shrinking a small list by corona10 · Pull Request #158787 · python/cpython · GitHub
Skip to content

gh-158592: Skip reallocation when shrinking a small list #158787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 9 commits into from
Oct 7, 2026
Merged

gh-158592: Skip reallocation when shrinking a small list #158787

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bbad8e9
gh-158592: Skip reallocation when shrinking a small list
corona10 Oct 4, 2026
23ad656
Address code review
corona10 Oct 4, 2026
5cd80db
Address code review
corona10 Oct 5, 2026
89b411f
Address code review
corona10 Oct 5, 2026
a4f3cff
Apply suggestion from @picnixz
corona10 Oct 5, 2026
dd855fd
Revert "Apply suggestion from @picnixz"
corona10 Oct 5, 2026
3404db8
Address code review
corona10 Oct 6, 2026
6cd6e2a
nit
corona10 Oct 6, 2026
f01205b
Merge branch 'main' into gh-158592
corona10 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@corona10
corona10 committed Oct 6, 2026
commit 6cd6e2a4e2bd671546345ad9dd16a9a2491b7f65
3 changes: 1 addition & 2 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ static int py_list_resize(PyListObject *self, Py_ssize_t newsize);
* Note that self->ob_item may change, and even if newsize is less
* than ob_size on entry.
*
* list_resize() only handles the fast path that does not need realloc().
* Always inlining this function makes the fast path a few instructions
* Always inlining list_resize() makes the fast path a few instructions
* in each caller instead of a function call.
*/
static inline Py_ALWAYS_INLINE int
Comment thread
ZeroIntensity marked this conversation as resolved.
Expand Down
Loading