Visitar URL original
gh-158592: Skip reallocation when shrinking a small list by corona10 · Pull Request #158787 · python/cpython · GitHub
Skip to content

gh-158592: Skip reallocation when shrinking a small list #158787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 9 commits into from
Oct 7, 2026
Merged

gh-158592: Skip reallocation when shrinking a small list #158787

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bbad8e9
gh-158592: Skip reallocation when shrinking a small list
corona10 Oct 4, 2026
23ad656
Address code review
corona10 Oct 4, 2026
5cd80db
Address code review
corona10 Oct 5, 2026
89b411f
Address code review
corona10 Oct 5, 2026
a4f3cff
Apply suggestion from @picnixz
corona10 Oct 5, 2026
dd855fd
Revert "Apply suggestion from @picnixz"
corona10 Oct 5, 2026
3404db8
Address code review
corona10 Oct 6, 2026
6cd6e2a
nit
corona10 Oct 6, 2026
f01205b
Merge branch 'main' into gh-158592
corona10 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Apply suggestion from @picnixz" 
This reverts commit 134f2fd.
  • Loading branch information
@corona10
corona10 committed Oct 5, 2026
commit dd855fdf74dbf62e60d2212a88b2d1f1a0717204
6 changes: 2 additions & 4 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-10-04-11-59-33.gh-issue-158592._BpoeY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
Skip the array reallocation when shrinking a small :class:`list`-
When deleting an item from a list via :keyword:`del`, lists are
also now correctly reallocated unless small, thereby avoiding
holding memory for too long. Patch by Donghee Na.
Skip the array reallocation when shrinking a small :class:`list`. Patch by

@eendebakpt eendebakpt Oct 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But large arrays are re-allocated! This PR solves a bug (feature?), which should be in the news entry.

@corona10 corona10 Oct 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eendebakpt NEWS.d of https://github.com/python/cpython/pull/158602will cover this. In Core team Discord @picnixz and I decide to merge in separated PR.

Donghee Na.
Comment thread
corona10 marked this conversation as resolved.
Loading