Visitar URL original
fix(files): cap how long a room delivery waits for its refetches by waleedlatif1 · Pull Request #9427 · simstudioai/sim · GitHub
Skip to content

fix(files): cap how long a room delivery waits for its refetches #9427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Oct 29, 2026
Merged

fix(files): cap how long a room delivery waits for its refetches #9427

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77050d4
fix(files): cap how long a room delivery waits for its refetches
waleedlatif1 Oct 29, 2026
4aec312
docs(files): say which hung refetches a capped room delivery recovers
waleedlatif1 Oct 29, 2026
bf44de4
fix(files): cap a room delivery's wait at a minute, above the slowest…
waleedlatif1 Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(files): say which hung refetches a capped room delivery recovers
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Oct 29, 2026
commit 4aec312620a0fd99786eed28d6c6316422ca4d5e
5 changes: 3 additions & 2 deletions apps/sim/app/workspace/[workspaceId]/hooks/use-workspace-invalidation-room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ const JOIN_RETRY_BASE_MS = 1000
export const INVALIDATION_COALESCE_MS = 1000
/**
* The longest a delivery waits for its refetches. A fetch has no timeout of its own, so one that
* hangs would otherwise hold the room's deliveries forever; past this, the next delivery's
* invalidation cancels and restarts it.
* hangs would otherwise hold the room's deliveries forever. Past this, later deliveries run again:
* their invalidation cancels and restarts a hung refetch of a query that has data, while a hung
* first load is joined, as it always was, until it settles or its last observer unmounts.
*/
export const DELIVERY_SETTLE_CAP_MS = 30_000

Expand Down
Loading