Visitar URL original
fix(files): cap how long a room delivery waits for its refetches by waleedlatif1 · Pull Request #9427 · simstudioai/sim · GitHub
Skip to content

fix(files): cap how long a room delivery waits for its refetches #9427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Oct 29, 2026
Merged

fix(files): cap how long a room delivery waits for its refetches #9427

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77050d4
fix(files): cap how long a room delivery waits for its refetches
waleedlatif1 Oct 29, 2026
4aec312
docs(files): say which hung refetches a capped room delivery recovers
waleedlatif1 Oct 29, 2026
bf44de4
fix(files): cap a room delivery's wait at a minute, above the slowest…
waleedlatif1 Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(files): cap a room delivery's wait at a minute, above the slowest… 
… list read
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Oct 29, 2026
commit bf44de48c4aa3094a8a80908e6127df8dd1a592d
6 changes: 4 additions & 2 deletions apps/sim/app/workspace/[workspaceId]/hooks/use-workspace-invalidation-room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ export const INVALIDATION_COALESCE_MS = 1000
* The longest a delivery waits for its refetches. A fetch has no timeout of its own, so one that
* hangs would otherwise hold the room's deliveries forever. Past this, later deliveries run again:
* their invalidation cancels and restarts a hung refetch of a query that has data, while a hung
* first load is joined, as it always was, until it settles or its last observer unmounts.
* first load is joined, as it always was, until it settles or its last observer unmounts. A refetch
* still progressing past the cap is restarted the same way, so the cap sits well above the
* slowest list read seen.
*/
export const DELIVERY_SETTLE_CAP_MS = 30_000
export const DELIVERY_SETTLE_CAP_MS = 60_000

interface JoinErrorPayload {
workspaceId: string
Expand Down
Loading