Visitar URL original
USWDS - Feature: Aria-hide lock icon and flag in banner · Issue #4912 · uswds/uswds · GitHub
Skip to content

USWDS - Feature: Aria-hide lock icon and flag in banner #4912

Closed
#4925
Closed
USWDS - Feature: Aria-hide lock icon and flag in banner#4912
#4925
Assignees
amyleadem
Labels
Added during SprintHistorical record of work added during a sprint. Not required for current triage.Affects: Accessibility 🟡Affects access for disabled users or assistive tech. Record the barrier; not a severity score.
Milestone
uswds 3.2.0

Description

@werdnanoslen
werdnanoslen
opened on Aug 8, 2022

Is your feature request related to a problem? Please describe.

There are some graphical elements in the banner that are purely visual and add unnecessary content for screenreaders.

Describe the solution you'd like

The lock icon and surrounding parentheses can be made aria-hidden, as it only communicates visual information.

uswds/packages/usa-banner/src/usa-banner.twig

Line 39 in aa119d4

<p><strong>{{ https.heading }}</strong><br/>{{ https.pretext | trim | raw }} ({{ lock }}) {{ https.posttext | trim | raw }}</p>

image

Ditto for the flag image, which is purely decorative:

uswds/packages/usa-banner/src/usa-banner.twig

Line 16 in aa119d4

<img class="usa-banner__header-flag" src="./img/us_flag_small.png" alt="U.S. flag">

image

Describe alternatives you've considered

No response

Additional context

No response

Code of Conduct

Activity

  1. werdnanoslen
    added
    Status: Triage
    Type: Feature RequestCompatibility label; native Enhancement type is authoritative. Retained for templates/search links.
    on Aug 8, 2022
  2. thisisdano
    added this to USWDS Core Project Dataon Aug 8, 2022
  3. amyleadem
    self-assigned this
    on Aug 19, 2022
  4. amyleadem
    added
    Type: Enhancement
    Affects: Accessibility 🟡Affects access for disabled users or assistive tech. Record the barrier; not a severity score.
    Status: Active 🟢
    Added during SprintHistorical record of work added during a sprint. Not required for current triage.
    and removed
    Type: Feature RequestCompatibility label; native Enhancement type is authoritative. Retained for templates/search links.
    Status: Triage
    on Aug 19, 2022
  5. amyleadem
    moved this to In progress in USWDS Core Project Dataon Aug 22, 2022
  6. amyleadem
    moved this from In progress to Review in USWDS Core Project Dataon Aug 23, 2022
  7. mejiaj
    moved this from Review to Fed Final Review in USWDS Core Project Dataon Sep 9, 2022
  8. thisisdano
    closed this as completedin #4925on Sep 26, 2022
  9. Repository owner moved this from Fed Final Review to Done in USWDS Core Project Dataon Sep 26, 2022
  10. thisisdano
    added this to the uswds 3.2.0 milestone on Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Added during SprintHistorical record of work added during a sprint. Not required for current triage.Affects: Accessibility 🟡Affects access for disabled users or assistive tech. Record the barrier; not a severity score.

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions