USWDS - update data prop for consistency - #6688

Summary

Standardized the in-page navigation component to use data-enhanced instead of data-created to match the convention established in other components, Rolled back a previous edit to the tooltip test while a decision is pending on how to handle tooltips in assistive tech.

Breaking change

This is not a breaking change. This change is purely internal to component initialization and does not affect any public APIs or user-facing behavior.

Related issue

Closes #6687

Preview link

Preview link: N/A

Problem statement

I was reviewing PR #6664 and planning on requesting these changes from the original submitter, but the PR was merged before I was able to submit my review. These changes address the comments I was going to leave.

Desired state: Component initialization guards should use consistent naming conventions across the codebase, making it easier for developers to understand and maintain the code.

Actual state: The in-page navigation component used data-created as its idempotency guard while other components (character count, date picker, file input, range) use data-enhanced. Additionally, aria-label was added to a file by a merged contribution, which may in conflict with USWDS

Consequences: Inconsistent naming conventions increase cognitive load for developers and make the codebase harder to navigate.

Solution

I changed the in-page navigation component's initialized check from dataset.created to dataset.enhanced. I left the a11y aria-label on the SVG with role="img" (which requires an accessible name per our CI checks) and removed aria-label from <a> and <span> elements where title already provides the accessible text.

Using data-enhanced aligns with the established pattern in other USWDS components that perform DOM enhancement (e.g. character-count, date-picker, file-input, range). This consistency makes it easier to search for enhancement logic across the codebase and understand component initialization patterns.